[jira] [Commented] (THRIFT-3134) Remove use of deprecated "phantom.args"

["Nobuaki Sukegawa (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537255#comment-14537255 ] 

Nobuaki Sukegawa commented on THRIFT-3134:
------------------------------------------

https://github.com/apache/thrift/pull/487

> Remove use of deprecated "phantom.args"
> ---------------------------------------
>
>                 Key: THRIFT-3134
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3134
>             Project: Thrift
>          Issue Type: Improvement
>          Components: JavaScript - Library, Test Suite
>         Environment: NodeJS 0.12.2
> npm 2.9.0
> ArchLinux
>            Reporter: Nobuaki Sukegawa
>            Priority: Minor
>
> JS library test uses {{phantom.args}} which is deprecated at least since Oct 29, 2011[1] and removed from PhantomJS 2.
> Build log shows that the build system tries to find phantom 1.X but for some reason, in my environment, it uses phantom2 and the test fails.
> The failure may only be a configuration problem but removing use of deprecated API would be a good idea.
> [1] https://code.google.com/p/phantomjs/issues/detail?id=276



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)