You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Kenji Matsuoka (JIRA)" <ji...@apache.org> on 2007/01/18 20:23:30 UTC
[jira] Created: (HADOOP-905) Code qualify inputDirs qualified
doesn't affect path validation
Code qualify inputDirs qualified doesn't affect path validation
---------------------------------------------------------------
Key: HADOOP-905
URL: https://issues.apache.org/jira/browse/HADOOP-905
Project: Hadoop
Issue Type: Bug
Components: fs
Affects Versions: 0.10.1
Reporter: Kenji Matsuoka
This code, at JobClient:306, doesn't seem to do anything, since inputDirs is a newly created arrray:
Path[] inputDirs = job.getInputPaths();
// make sure directories are fully qualified before checking them
for(int i=0; i < inputDirs.length; ++i) {
if (inputDirs[i].toUri().getScheme() == null) {
inputDirs[i] = userFileSys.makeQualified(inputDirs[i]);
}
}
// input paths should exist.
job.getInputFormat().validateInput(job);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-905) Code to qualify inputDirs doesn't
affect path validation
Posted by "Kenji Matsuoka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kenji Matsuoka updated HADOOP-905:
----------------------------------
Summary: Code to qualify inputDirs doesn't affect path validation (was: Code qualify inputDirs qualified doesn't affect path validation)
> Code to qualify inputDirs doesn't affect path validation
> --------------------------------------------------------
>
> Key: HADOOP-905
> URL: https://issues.apache.org/jira/browse/HADOOP-905
> Project: Hadoop
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.10.1
> Reporter: Kenji Matsuoka
>
> This code, at JobClient:306, doesn't seem to do anything, since inputDirs is a newly created arrray:
> Path[] inputDirs = job.getInputPaths();
>
> // make sure directories are fully qualified before checking them
> for(int i=0; i < inputDirs.length; ++i) {
> if (inputDirs[i].toUri().getScheme() == null) {
> inputDirs[i] = userFileSys.makeQualified(inputDirs[i]);
> }
> }
> // input paths should exist.
> job.getInputFormat().validateInput(job);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-905) Code to qualify inputDirs doesn't
affect path validation
Posted by "Kenji Matsuoka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kenji Matsuoka updated HADOOP-905:
----------------------------------
Description:
This code, at JobClient:306, doesn't seem to do validate the fully qualified inputDirs, since inputDirs is a newly created arrray:
Path[] inputDirs = job.getInputPaths();
// make sure directories are fully qualified before checking them
for(int i=0; i < inputDirs.length; ++i) {
if (inputDirs[i].toUri().getScheme() == null) {
inputDirs[i] = userFileSys.makeQualified(inputDirs[i]);
}
}
// input paths should exist.
job.getInputFormat().validateInput(job);
was:
This code, at JobClient:306, doesn't seem to do anything, since inputDirs is a newly created arrray:
Path[] inputDirs = job.getInputPaths();
// make sure directories are fully qualified before checking them
for(int i=0; i < inputDirs.length; ++i) {
if (inputDirs[i].toUri().getScheme() == null) {
inputDirs[i] = userFileSys.makeQualified(inputDirs[i]);
}
}
// input paths should exist.
job.getInputFormat().validateInput(job);
> Code to qualify inputDirs doesn't affect path validation
> --------------------------------------------------------
>
> Key: HADOOP-905
> URL: https://issues.apache.org/jira/browse/HADOOP-905
> Project: Hadoop
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.10.1
> Reporter: Kenji Matsuoka
>
> This code, at JobClient:306, doesn't seem to do validate the fully qualified inputDirs, since inputDirs is a newly created arrray:
> Path[] inputDirs = job.getInputPaths();
>
> // make sure directories are fully qualified before checking them
> for(int i=0; i < inputDirs.length; ++i) {
> if (inputDirs[i].toUri().getScheme() == null) {
> inputDirs[i] = userFileSys.makeQualified(inputDirs[i]);
> }
> }
> // input paths should exist.
> job.getInputFormat().validateInput(job);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HADOOP-905) Code to qualify inputDirs doesn't
affect path validation
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting resolved HADOOP-905.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.11.0
I fixed this, removing the dead code.
> Code to qualify inputDirs doesn't affect path validation
> --------------------------------------------------------
>
> Key: HADOOP-905
> URL: https://issues.apache.org/jira/browse/HADOOP-905
> Project: Hadoop
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.10.1
> Reporter: Kenji Matsuoka
> Fix For: 0.11.0
>
>
> This code, at JobClient:306, doesn't seem to validate the fully qualified inputDirs, since inputDirs is a newly created arrray:
> Path[] inputDirs = job.getInputPaths();
>
> // make sure directories are fully qualified before checking them
> for(int i=0; i < inputDirs.length; ++i) {
> if (inputDirs[i].toUri().getScheme() == null) {
> inputDirs[i] = userFileSys.makeQualified(inputDirs[i]);
> }
> }
> // input paths should exist.
> job.getInputFormat().validateInput(job);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-905) Code to qualify inputDirs doesn't
affect path validation
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465848 ]
Doug Cutting commented on HADOOP-905:
-------------------------------------
Yes, this looks like dead code, left over from a prior version. It should be removed, as the paths are now fully-qualified in InputFormatBase. Thanks for noticing this!
> Code to qualify inputDirs doesn't affect path validation
> --------------------------------------------------------
>
> Key: HADOOP-905
> URL: https://issues.apache.org/jira/browse/HADOOP-905
> Project: Hadoop
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.10.1
> Reporter: Kenji Matsuoka
>
> This code, at JobClient:306, doesn't seem to validate the fully qualified inputDirs, since inputDirs is a newly created arrray:
> Path[] inputDirs = job.getInputPaths();
>
> // make sure directories are fully qualified before checking them
> for(int i=0; i < inputDirs.length; ++i) {
> if (inputDirs[i].toUri().getScheme() == null) {
> inputDirs[i] = userFileSys.makeQualified(inputDirs[i]);
> }
> }
> // input paths should exist.
> job.getInputFormat().validateInput(job);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-905) Code to qualify inputDirs doesn't
affect path validation
Posted by "Kenji Matsuoka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kenji Matsuoka updated HADOOP-905:
----------------------------------
Description:
This code, at JobClient:306, doesn't seem to validate the fully qualified inputDirs, since inputDirs is a newly created arrray:
Path[] inputDirs = job.getInputPaths();
// make sure directories are fully qualified before checking them
for(int i=0; i < inputDirs.length; ++i) {
if (inputDirs[i].toUri().getScheme() == null) {
inputDirs[i] = userFileSys.makeQualified(inputDirs[i]);
}
}
// input paths should exist.
job.getInputFormat().validateInput(job);
was:
This code, at JobClient:306, doesn't seem to do validate the fully qualified inputDirs, since inputDirs is a newly created arrray:
Path[] inputDirs = job.getInputPaths();
// make sure directories are fully qualified before checking them
for(int i=0; i < inputDirs.length; ++i) {
if (inputDirs[i].toUri().getScheme() == null) {
inputDirs[i] = userFileSys.makeQualified(inputDirs[i]);
}
}
// input paths should exist.
job.getInputFormat().validateInput(job);
> Code to qualify inputDirs doesn't affect path validation
> --------------------------------------------------------
>
> Key: HADOOP-905
> URL: https://issues.apache.org/jira/browse/HADOOP-905
> Project: Hadoop
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.10.1
> Reporter: Kenji Matsuoka
>
> This code, at JobClient:306, doesn't seem to validate the fully qualified inputDirs, since inputDirs is a newly created arrray:
> Path[] inputDirs = job.getInputPaths();
>
> // make sure directories are fully qualified before checking them
> for(int i=0; i < inputDirs.length; ++i) {
> if (inputDirs[i].toUri().getScheme() == null) {
> inputDirs[i] = userFileSys.makeQualified(inputDirs[i]);
> }
> }
> // input paths should exist.
> job.getInputFormat().validateInput(job);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira