You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/02 14:58:52 UTC

[GitHub] [flink] wangyang0918 edited a comment on issue #9986: [FLINK-10933][kubernetes] Implement KubernetesSessionClusterEntrypoint.

wangyang0918 edited a comment on issue #9986: [FLINK-10933][kubernetes] Implement KubernetesSessionClusterEntrypoint.
URL: https://github.com/apache/flink/pull/9986#issuecomment-560429396
 
 
   @zhijiangW Thanks for your review. You are right. It is good to add some unit tests. However, the new classes are too simple -:)
   Compared with Yarn implementation, it is same.
   I will remove the changes of `KubernetesClusterDescriptor` so that this PR could be merged quickly.
   
   Please take a look and help to merge.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services