You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ajantha-bhat (via GitHub)" <gi...@apache.org> on 2023/04/06 06:52:25 UTC
[GitHub] [iceberg] ajantha-bhat opened a new pull request, #7286: Core: Fix errorprone warning
ajantha-bhat opened a new pull request, #7286:
URL: https://github.com/apache/iceberg/pull/7286
<img width="852" alt="Screenshot 2023-04-06 at 12 18 53 PM" src="https://user-images.githubusercontent.com/5889404/230294510-47983abd-5a41-4e93-a304-3eea0f103053.png">
Keeping the build clean [`./gradlew clean build -x test -x integrationTest`]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #7286: Core: Fix errorprone warning
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #7286:
URL: https://github.com/apache/iceberg/pull/7286#discussion_r1159413996
##########
core/src/main/java/org/apache/iceberg/inmemory/InMemoryInputFile.java:
##########
@@ -75,7 +75,7 @@ private static class InMemorySeekableInputStream extends SeekableInputStream {
@Override
public long getPos() throws IOException {
checkOpen();
- return length - delegate.available();
+ return (long) length - delegate.available();
Review Comment:
I would rather make `length` a long a few lines above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #7286: Core: Fix errorprone warning
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #7286:
URL: https://github.com/apache/iceberg/pull/7286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #7286: Core: Fix errorprone warning
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #7286:
URL: https://github.com/apache/iceberg/pull/7286#discussion_r1161399521
##########
core/src/main/java/org/apache/iceberg/inmemory/InMemoryInputFile.java:
##########
@@ -75,7 +75,7 @@ private static class InMemorySeekableInputStream extends SeekableInputStream {
@Override
public long getPos() throws IOException {
checkOpen();
- return length - delegate.available();
+ return (long) length - delegate.available();
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #7286: Core: Fix errorprone warning
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #7286:
URL: https://github.com/apache/iceberg/pull/7286#issuecomment-1498578824
cc: @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org