You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/05 08:07:33 UTC

[GitHub] [camel-k-runtime] lburgazzoli opened a new pull request #543: Switch to Quarkus as runtime #359

lburgazzoli opened a new pull request #543:
URL: https://github.com/apache/camel-k-runtime/pull/543


   <!-- Description -->
   
   
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   NONE
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k-runtime] nicolaferraro commented on pull request #543: Switch to Quarkus as runtime #359

Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #543:
URL: https://github.com/apache/camel-k-runtime/pull/543#issuecomment-724092540


   Is this right? https://github.com/apache/camel-k-runtime/blob/00d401e5e875d0e4d186edc4f00266f64bb68ed3/support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/processors/CatalogProcessor3x.java#L148


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k-runtime] nicolaferraro commented on pull request #543: Switch to Quarkus as runtime #359

Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #543:
URL: https://github.com/apache/camel-k-runtime/pull/543#issuecomment-724077784


   I got something wrong in the catalog:
   
   ```
       camel-k-cron:
         groupId: org.apache.camel.k
         artifactId: camel-k-cron
         schemes:
         - id: cron
           http: true
           passive: false
       camel-k-kamelet:
         groupId: org.apache.camel.k
         artifactId: camel-k-kamelet
         schemes:
         - id: kamelet
           http: false
           passive: true
   ```
   
   Cron is not http, while kamelet is not necessarily passive (most of the times it's active actually).
   We've already had a discussion about kamelets but I don't remember what was the right way to set it... I mean there's no good way probably, but how we deal with them?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k-runtime] lburgazzoli commented on pull request #543: Switch to Quarkus as runtime #359

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #543:
URL: https://github.com/apache/camel-k-runtime/pull/543#issuecomment-724097624


   > Is this right?
   > 
   > https://github.com/apache/camel-k-runtime/blob/00d401e5e875d0e4d186edc4f00266f64bb68ed3/support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/processors/CatalogProcessor3x.java#L148
   
   no


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k-runtime] lburgazzoli merged pull request #543: Switch to Quarkus as runtime #359

Posted by GitBox <gi...@apache.org>.
lburgazzoli merged pull request #543:
URL: https://github.com/apache/camel-k-runtime/pull/543


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k-runtime] nicolaferraro commented on pull request #543: Switch to Quarkus as runtime #359

Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #543:
URL: https://github.com/apache/camel-k-runtime/pull/543#issuecomment-724083422


   > I got something wrong in the catalog:
   > 
   > ```
   >     camel-k-cron:
   >       groupId: org.apache.camel.k
   >       artifactId: camel-k-cron
   >       schemes:
   >       - id: cron
   >         http: true
   >         passive: false
   >     camel-k-kamelet:
   >       groupId: org.apache.camel.k
   >       artifactId: camel-k-kamelet
   >       schemes:
   >       - id: kamelet
   >         http: false
   >         passive: true
   > ```
   > 
   > Cron is not http, while kamelet is not necessarily passive (most of the times it's active actually).
   > We've already had a discussion about kamelets but I don't remember what was the right way to set it... I mean there's no good way probably, but how we deal with them?
   
   Ok, kamelet should be right, because the template is added as additional source and analyzed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org