You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/12 09:06:22 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
AngersZhuuuu opened a new pull request #30350:
URL: https://github.com/apache/spark/pull/30350
### What changes were proposed in this pull request?
Use Long value store encode value will overflow and return unexpected result, use BigInt to replace Long value and make logical more simple.
### Why are the changes needed?
Fix value overflow issue
### Does this PR introduce _any_ user-facing change?
People can sue `conf` function to convert value big then LONG.MAX_VALUE
### How was this patch tested?
Added UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-743008662
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37231/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-738571120
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36784/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744198530
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37346/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726483658
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #30350:
URL: https://github.com/apache/spark/pull/30350#discussion_r521974807
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
##########
@@ -159,7 +159,7 @@ class MathExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
test("conv") {
checkEvaluation(Conv(Literal("3"), Literal(10), Literal(2)), "11")
checkEvaluation(Conv(Literal("-15"), Literal(10), Literal(-16)), "-F")
Review comment:
In BigInteger
```
public String toString(int radix) {
if (signum == 0)
return "0";
if (radix < Character.MIN_RADIX || radix > Character.MAX_RADIX)
radix = 10;
// If it's small enough, use smallToString.
if (mag.length <= SCHOENHAGE_BASE_CONVERSION_THRESHOLD)
return smallToString(radix);
// Otherwise use recursive toString, which requires positive arguments.
// The results will be concatenated into this StringBuilder
StringBuilder sb = new StringBuilder();
if (signum < 0) {
toString(this.negate(), sb, radix, 0);
sb.insert(0, '-');
}
else
toString(this, sb, radix, 0);
return sb.toString();
}
```
`Character.MIN_RADIX`'s value is 2, so any radix less then 2 will be convert to default `10`, should we keep the same behavior？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726008584
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130986/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-735410217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-725947556
**[Test build #130986 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130986/testReport)** for PR 30350 at commit [`6b2c41d`](https://github.com/apache/spark/commit/6b2c41dad30d812abeec96dd4a803db1adbac1a2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726642758
**[Test build #131051 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131051/testReport)** for PR 30350 at commit [`6dcad9f`](https://github.com/apache/spark/commit/6dcad9f18e7938350c8a1aed14e55d6ca2165154).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737856753
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36710/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726008571
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731985607
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744190241
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132743/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731958566
**[Test build #131538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131538/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726160466
**[Test build #131001 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131001/testReport)** for PR 30350 at commit [`1ccb5f3`](https://github.com/apache/spark/commit/1ccb5f39ca86f421c19c803cfbd5ee66a4d10eeb).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-741674093
ping @cloud-fan @srowen Any more update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737774633
**[Test build #132111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132111/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726505378
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35641/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744120950
**[Test build #132735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132735/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726518675
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737690572
> Fixing overflow should be good. It's not very intuitive to read the results of this function. Is there any database we can use as a reference?
Mysql: https://dev.mysql.com/doc/refman/8.0/en/mathematical-functions.html#function_conv
But still only support 64-bit presicion.
Hive: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF
Latest version support BigInt now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731996512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726591062
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726121391
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35607/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737699065
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731958067
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131526/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731996512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731958056
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732672159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-742987477
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744479266
Since the overflow behavior is expected, this is more like an improvement instead of a bug fix. Thus, I'm merging it to master only, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726483205
**[Test build #131027 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131027/testReport)** for PR 30350 at commit [`f384c89`](https://github.com/apache/spark/commit/f384c8964c93a68b774c6ff79b767481b4564dcd).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726472213
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35633/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726642758
**[Test build #131051 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131051/testReport)** for PR 30350 at commit [`6dcad9f`](https://github.com/apache/spark/commit/6dcad9f18e7938350c8a1aed14e55d6ca2165154).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726591062
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731957340
**[Test build #131526 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131526/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #30350:
URL: https://github.com/apache/spark/pull/30350#discussion_r528202880
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala
##########
@@ -21,64 +21,37 @@ import org.apache.spark.unsafe.types.UTF8String
object NumberConverter {
- /**
- * Divide x by m as if x is an unsigned 64-bit integer. Examples:
- * unsignedLongDiv(-1, 2) == Long.MAX_VALUE unsignedLongDiv(6, 3) == 2
- * unsignedLongDiv(0, 5) == 0
- *
- * @param x is treated as unsigned
- * @param m is treated as signed
- */
- private def unsignedLongDiv(x: Long, m: Int): Long = {
- if (x >= 0) {
- x / m
- } else {
- // Let uval be the value of the unsigned long with the same bits as x
- // Two's complement => x = uval - 2*MAX - 2
- // => uval = x + 2*MAX + 2
- // Now, use the fact: (a+b)/c = a/c + b/c + (a%c+b%c)/c
- x / m + 2 * (Long.MaxValue / m) + 2 / m + (x % m + 2 * (Long.MaxValue % m) + 2 % m) / m
- }
- }
-
/**
* Decode v into value[].
*
* @param v is treated as an unsigned 64-bit integer
* @param radix must be between MIN_RADIX and MAX_RADIX
*/
- private def decode(v: Long, radix: Int, value: Array[Byte]): Unit = {
+ private def decode(v: BigInt, radix: Int, value: Array[Byte]): Unit = {
Review comment:
@cloud-fan Have update a benchmark result in PR desc, please check the performance inpact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-738541351
**[Test build #132184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132184/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744131448
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37336/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732069700
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744198505
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37346/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731901071
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36128/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-738571120
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36784/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726160796
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131001/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744137790
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37336/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732033554
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36144/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744186177
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37346/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-735887274
> It's a behavior change which could be OK if it's a bug fix. Do SQL standards have anything to say about what the result should be?
Didn't find the place to describe this exactly in SQL standards. It's a function from hive and I prepare to make a pr in hive too.
From the benchmark, seems have little influence in performance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732069300
**[Test build #131541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131541/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-743102502
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132628/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732033566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-725995109
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35592/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-738564581
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36784/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731997541
**[Test build #131541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131541/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744369134
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37365/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30350:
URL: https://github.com/apache/spark/pull/30350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732507166
**[Test build #131600 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131600/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-799921923
Yea, check the detail of mysql https://www.w3resource.com/mysql/mathematical-functions/mysql-conv-function.php
I means if to base is positive, we treat it as unsigned. then when overflow, it return `-1`(unsigned long value as `18446744073709551615` ), for current mysql behavior,
1. User always not clear about the overflow, so if we return overflow value, user may not known it.
2. Long can't satisfy current user's requirement, if we use a big decimal or bigint, we can't use this fuction.
3. Keep same with other engine is good.
4. For both keep same and satisfy user's requirement, should we revert this change and add a new function such as `conv_without_overflow`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-799988616
> I've reverted this commit.
>
> Regarding `conv_without_overflow`, are we going to disallow negative `toBase`? Does any other database have it?
Hmmm why do we need to disallow negative `toBase`. Doesn't find other database have it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737932382
**[Test build #132111 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132111/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu edited a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737690572
> Fixing overflow should be good. It's not very intuitive to read the results of this function. Is there any database we can use as a reference?
Mysql: https://dev.mysql.com/doc/refman/8.0/en/mathematical-functions.html#function_conv
But still only support 64-bit presicion.
Hive: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF
https://github.com/apache/hive/blob/9cc3dc4830466ae9a744ea3442872f9289b917d1/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFConv.java#L94-L109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-738556087
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36784/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744168499
**[Test build #132743 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132743/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-800012610
> If we never overflow, why do we need to return unsigned results?
Hmmm you mean negative number? `conv(number, fromBase, toBase)`. This pr won't change behavior when negative `toBase`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744117862
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726677220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-800070099
Do we still need this signed vs unsigned difference in the `conv` function if it never overflows?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732660678
**[Test build #131600 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131600/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744271135
the scala 2.13 build is broken:
```
[error] /home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala:36:46: Byte does not take parameters
[error] value(i) = (tmpV - q * radix).byteValue()
[error]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744457021
**[Test build #132763 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132763/testReport)** for PR 30350 at commit [`8564e0f`](https://github.com/apache/spark/commit/8564e0f5761c0fcc3d013f7212a470e61938f78a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726140233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732507166
**[Test build #131600 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131600/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731958026
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-735403980
**[Test build #131930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131930/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744137771
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37336/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744369048
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37365/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-743101647
**[Test build #132628 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132628/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-743102502
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132628/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-799975753
I've reverted this commit.
Regarding `conv_without_overflow`, are we going to disallow negative `toBase`? Does any other database have it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-738591660
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132184/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737856775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744137790
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37336/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737817719
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36710/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-799997530
If we never overflow, why do we need to return unsigned results?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744291948
**[Test build #132763 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132763/testReport)** for PR 30350 at commit [`8564e0f`](https://github.com/apache/spark/commit/8564e0f5761c0fcc3d013f7212a470e61938f78a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732033566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-735403980
**[Test build #131930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131930/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744369134
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37365/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744459338
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132763/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737715812
**[Test build #132100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132100/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726830363
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #30350:
URL: https://github.com/apache/spark/pull/30350#discussion_r521963676
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
##########
@@ -159,7 +159,7 @@ class MathExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
test("conv") {
checkEvaluation(Conv(Literal("3"), Literal(10), Literal(2)), "11")
checkEvaluation(Conv(Literal("-15"), Literal(10), Literal(-16)), "-F")
Review comment:
Is it correct?
```scala
scala> new java.math.BigInteger("-15", 10).toString(16)
res13: String = -f
scala> new java.math.BigInteger("-15", 10).toString(-16)
res14: String = -15
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744365193
> value(i) = (tmpV - q * radix).byteValue()
Thanks for mention this point
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-743033348
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37231/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744163995
**[Test build #132735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132735/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726450557
**[Test build #131027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131027/testReport)** for PR 30350 at commit [`f384c89`](https://github.com/apache/spark/commit/f384c8964c93a68b774c6ff79b767481b4564dcd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726008571
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744166802
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132735/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-738541351
**[Test build #132184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132184/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726591069
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131035/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732069709
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131541/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731996617
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-799894002
> I found a behavior change here.
>
> Before this commit
>
> ```
> scala> sql("select conv(-100, 10, 10)").show(20, false)
> +----------------------------------+
> |conv(CAST(-100 AS STRING), 10, 10)|
> +----------------------------------+
> |18446744073709551516 |
> +----------------------------------+
> ```
>
> After this commit
>
> ```
> scala> sql("select conv(-100, 10, 10)").show(20, false)
> +------------------+
> |conv(-100, 10, 10)|
> +------------------+
> |-100 |
> +------------------+
> ```
>
> If the `toBase` is positive, the result is unsigned. It's a bit hard to reason about how to put a negative value into an unsigned value, but MySQL returns the same result as before this commit and the overflow behavior seems to be desirable. @AngersZhuuuu can you take a look?
Got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-738525538
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726494559
**[Test build #131035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131035/testReport)** for PR 30350 at commit [`6dcad9f`](https://github.com/apache/spark/commit/6dcad9f18e7938350c8a1aed14e55d6ca2165154).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726662390
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35655/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737839277
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36713/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-735399107
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731958056
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726472230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726006150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737774633
**[Test build #132111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132111/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737715812
**[Test build #132100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132100/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-742988329
**[Test build #132628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132628/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-742988329
**[Test build #132628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132628/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737984894
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744291948
**[Test build #132763 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132763/testReport)** for PR 30350 at commit [`8564e0f`](https://github.com/apache/spark/commit/8564e0f5761c0fcc3d013f7212a470e61938f78a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726140233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726160784
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731958566
**[Test build #131538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131538/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-735441622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726140206
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35607/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744166802
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132735/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737727021
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36700/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737984925
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737741153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732702434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726053850
**[Test build #131001 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131001/testReport)** for PR 30350 at commit [`1ccb5f3`](https://github.com/apache/spark/commit/1ccb5f39ca86f421c19c803cfbd5ee66a4d10eeb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726677205
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35655/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737862856
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36713/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732702434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744168499
**[Test build #132743 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132743/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726638310
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726463883
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35633/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726518675
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737856775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744167296
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726830363
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744198530
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37346/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731906990
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36128/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726006132
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35592/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731985573
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36141/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726160784
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732017400
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36144/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726518663
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35641/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-735441622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726450557
**[Test build #131027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131027/testReport)** for PR 30350 at commit [`f384c89`](https://github.com/apache/spark/commit/f384c8964c93a68b774c6ff79b767481b4564dcd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726006150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-738591660
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132184/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731975403
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36141/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731985607
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731996101
**[Test build #131538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131538/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744120950
**[Test build #132735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132735/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-743033348
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37231/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-735436981
**[Test build #131930 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131930/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737877098
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu edited a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737690572
> Fixing overflow should be good. It's not very intuitive to read the results of this function. Is there any database we can use as a reference?
Mysql: https://dev.mysql.com/doc/refman/8.0/en/mathematical-functions.html#function_conv
But still only support 64-bit presicion.
Hive: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF
Latest version support BigInt now but internal logic still use `long`..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu edited a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737690572
> Fixing overflow should be good. It's not very intuitive to read the results of this function. Is there any database we can use as a reference?
Mysql: https://dev.mysql.com/doc/refman/8.0/en/mathematical-functions.html#function_conv
But still only support 64-bit presicion.
Hive: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF
Latest version support BigInt now but internal logic still use `long`..
https://github.com/apache/hive/blob/9cc3dc4830466ae9a744ea3442872f9289b917d1/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFConv.java#L94-L109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737741153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726472230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732069700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #30350:
URL: https://github.com/apache/spark/pull/30350#discussion_r526913458
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala
##########
@@ -21,64 +21,37 @@ import org.apache.spark.unsafe.types.UTF8String
object NumberConverter {
- /**
- * Divide x by m as if x is an unsigned 64-bit integer. Examples:
- * unsignedLongDiv(-1, 2) == Long.MAX_VALUE unsignedLongDiv(6, 3) == 2
- * unsignedLongDiv(0, 5) == 0
- *
- * @param x is treated as unsigned
- * @param m is treated as signed
- */
- private def unsignedLongDiv(x: Long, m: Int): Long = {
- if (x >= 0) {
- x / m
- } else {
- // Let uval be the value of the unsigned long with the same bits as x
- // Two's complement => x = uval - 2*MAX - 2
- // => uval = x + 2*MAX + 2
- // Now, use the fact: (a+b)/c = a/c + b/c + (a%c+b%c)/c
- x / m + 2 * (Long.MaxValue / m) + 2 / m + (x % m + 2 * (Long.MaxValue % m) + 2 % m) / m
- }
- }
-
/**
* Decode v into value[].
*
* @param v is treated as an unsigned 64-bit integer
* @param radix must be between MIN_RADIX and MAX_RADIX
*/
- private def decode(v: Long, radix: Int, value: Array[Byte]): Unit = {
+ private def decode(v: BigInt, radix: Int, value: Array[Byte]): Unit = {
Review comment:
> Have you benchmarked it? In general, long is much faster than `BigInt`.
I will update a benchmark result later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737772458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731888422
**[Test build #131526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131526/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30350:
URL: https://github.com/apache/spark/pull/30350#discussion_r526900474
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala
##########
@@ -21,64 +21,37 @@ import org.apache.spark.unsafe.types.UTF8String
object NumberConverter {
- /**
- * Divide x by m as if x is an unsigned 64-bit integer. Examples:
- * unsignedLongDiv(-1, 2) == Long.MAX_VALUE unsignedLongDiv(6, 3) == 2
- * unsignedLongDiv(0, 5) == 0
- *
- * @param x is treated as unsigned
- * @param m is treated as signed
- */
- private def unsignedLongDiv(x: Long, m: Int): Long = {
- if (x >= 0) {
- x / m
- } else {
- // Let uval be the value of the unsigned long with the same bits as x
- // Two's complement => x = uval - 2*MAX - 2
- // => uval = x + 2*MAX + 2
- // Now, use the fact: (a+b)/c = a/c + b/c + (a%c+b%c)/c
- x / m + 2 * (Long.MaxValue / m) + 2 / m + (x % m + 2 * (Long.MaxValue % m) + 2 % m) / m
- }
- }
-
/**
* Decode v into value[].
*
* @param v is treated as an unsigned 64-bit integer
* @param radix must be between MIN_RADIX and MAX_RADIX
*/
- private def decode(v: Long, radix: Int, value: Array[Byte]): Unit = {
+ private def decode(v: BigInt, radix: Int, value: Array[Byte]): Unit = {
Review comment:
Have you benchmarked it? In general, long is much faster than `BigInt`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726677220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-732672159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744459338
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132763/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-736500450
Fixing overflow should be good. It's not very intuitive to read the results of this function. Is there any database we can use as a reference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726829025
**[Test build #131051 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131051/testReport)** for PR 30350 at commit [`6dcad9f`](https://github.com/apache/spark/commit/6dcad9f18e7938350c8a1aed14e55d6ca2165154).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726008370
**[Test build #130986 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130986/testReport)** for PR 30350 at commit [`6b2c41d`](https://github.com/apache/spark/commit/6b2c41dad30d812abeec96dd4a803db1adbac1a2).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726483664
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131027/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737877106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731907003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726590504
**[Test build #131035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131035/testReport)** for PR 30350 at commit [`6dcad9f`](https://github.com/apache/spark/commit/6dcad9f18e7938350c8a1aed14e55d6ca2165154).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726494559
**[Test build #131035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131035/testReport)** for PR 30350 at commit [`6dcad9f`](https://github.com/apache/spark/commit/6dcad9f18e7938350c8a1aed14e55d6ca2165154).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744332860
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37365/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737772632
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744187660
**[Test build #132743 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132743/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731888422
**[Test build #131526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131526/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-725947556
**[Test build #130986 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130986/testReport)** for PR 30350 at commit [`6b2c41d`](https://github.com/apache/spark/commit/6b2c41dad30d812abeec96dd4a803db1adbac1a2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726483658
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737772458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726053850
**[Test build #131001 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131001/testReport)** for PR 30350 at commit [`1ccb5f3`](https://github.com/apache/spark/commit/1ccb5f39ca86f421c19c803cfbd5ee66a4d10eeb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #30350:
URL: https://github.com/apache/spark/pull/30350#discussion_r521963676
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
##########
@@ -159,7 +159,7 @@ class MathExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
test("conv") {
checkEvaluation(Conv(Literal("3"), Literal(10), Literal(2)), "11")
checkEvaluation(Conv(Literal("-15"), Literal(10), Literal(-16)), "-F")
Review comment:
Is it correct?
```scala
scala> new java.math.BigInteger("-15", 10).toString(-16)
res4: String = -15
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-743021162
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37231/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-729331125
gentle ping @dongjoon-hyun @HyukjinKwon @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737716383
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36700/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731997541
**[Test build #131541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131541/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-735410217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-799671579
I found a behavior change here.
Before this commit
```
scala> sql("select conv(-100, 10, 10)").show(20, false)
+----------------------------------+
|conv(CAST(-100 AS STRING), 10, 10)|
+----------------------------------+
|18446744073709551516 |
+----------------------------------+
```
After this commit
```
scala> sql("select conv(-100, 10, 10)").show(20, false)
+------------------+
|conv(-100, 10, 10)|
+------------------+
|-100 |
+------------------+
```
If the `toBase` is positive, the result is unsigned. It's a bit hard to reason about how to put a negative value into an unsigned value, but MySQL returns the same result as before this commit and the overflow behavior seems to be desirable. @AngersZhuuuu can you take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744190241
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132743/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737771397
**[Test build #132100 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132100/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-738591217
**[Test build #132184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132184/testReport)** for PR 30350 at commit [`0e7221a`](https://github.com/apache/spark/commit/0e7221afa678064b55c813d9fe74360349abe907).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30350: [SPARK-33428][SQL] Conv UDF use BigInt to avoid Long value overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731907003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org