You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/06/16 06:58:40 UTC
[GitHub] [lucene] vigyasharma opened a new pull request, #963: LUCENE-10583: Add docstring warning to not lock on Lucene objects
vigyasharma opened a new pull request, #963:
URL: https://github.com/apache/lucene/pull/963
In [LUCENE-10583](https://issues.apache.org/jira/browse/LUCENE-10583), our users ran into a deadlock for IndexWriter threads. This was because the application had acquired a lock on the MMapDirectory, which was preventing merge threads from cleaning up files and completing.
The IndexWriter docstring does present a "Note", to use non-Lucene objects for locking, but no such warning was evident for the MMapDirectory. This PR is a small change to add a similar warning to MMapDirectory and Directory docstrings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] vigyasharma commented on pull request #963: LUCENE-10583: Add docstring warning to not lock on Lucene objects
Posted by GitBox <gi...@apache.org>.
vigyasharma commented on PR #963:
URL: https://github.com/apache/lucene/pull/963#issuecomment-1189846909
This is only a docstring change to warn users against locking on Lucene objects in commonly used classes. Do we think it makes sense to add this note?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand merged pull request #963: LUCENE-10583: Add docstring warning to not lock on Lucene objects
Posted by GitBox <gi...@apache.org>.
mikemccand merged PR #963:
URL: https://github.com/apache/lucene/pull/963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand commented on pull request #963: LUCENE-10583: Add docstring warning to not lock on Lucene objects
Posted by GitBox <gi...@apache.org>.
mikemccand commented on PR #963:
URL: https://github.com/apache/lucene/pull/963#issuecomment-1191325044
I backported to 9.x as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org