You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/06/24 23:50:27 UTC
[Impala-ASF-CR] IMPALA-8565: larger query in test admission controller
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13718
Change subject: IMPALA-8565: larger query in test_admission_controller
......................................................................
IMPALA-8565: larger query in test_admission_controller
It appears that in some rare cases, fragments from the
query used can finish too early, before the client has
started fetching to hit EOS.
Reduce the chances of this happening by increasing
the query size and reducing the fetch frequency.
Testing:
I could not reproduce this rare flake locally, probably
because my hardware is different from the hardware that
the failures occurred on.
I looped the failing test for a while locally to try and
ensure that the flakiness did not at least get worse.
Change-Id: Ifd7716d5d5ccc4b2f79b3acf2fbc880716b4c0fe
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 3 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/13718/1
--
To view, visit http://gerrit.cloudera.org:8080/13718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd7716d5d5ccc4b2f79b3acf2fbc880716b4c0fe
Gerrit-Change-Number: 13718
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8565: larger query in test admission controller
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13718 )
Change subject: IMPALA-8565: larger query in test_admission_controller
......................................................................
IMPALA-8565: larger query in test_admission_controller
It appears that in some rare cases, fragments from the
query used can finish too early, before the client has
started fetching to hit EOS.
Reduce the chances of this happening by increasing
the query size and reducing the fetch frequency.
Testing:
I could not reproduce this rare flake locally, probably
because my hardware is different from the hardware that
the failures occurred on.
I looped the failing test for a while locally to try and
ensure that the flakiness did not at least get worse.
Change-Id: Ifd7716d5d5ccc4b2f79b3acf2fbc880716b4c0fe
Reviewed-on: http://gerrit.cloudera.org:8080/13718
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 3 insertions(+), 41 deletions(-)
Approvals:
Bikramjeet Vig: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd7716d5d5ccc4b2f79b3acf2fbc880716b4c0fe
Gerrit-Change-Number: 13718
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8565: larger query in test admission controller
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13718 )
Change subject: IMPALA-8565: larger query in test_admission_controller
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4533/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd7716d5d5ccc4b2f79b3acf2fbc880716b4c0fe
Gerrit-Change-Number: 13718
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 05:29:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8565: larger query in test admission controller
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13718 )
Change subject: IMPALA-8565: larger query in test_admission_controller
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd7716d5d5ccc4b2f79b3acf2fbc880716b4c0fe
Gerrit-Change-Number: 13718
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 00:26:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8565: larger query in test admission controller
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has removed Joe McDonnell from this change. ( http://gerrit.cloudera.org:8080/13718 )
Change subject: IMPALA-8565: larger query in test_admission_controller
......................................................................
Removed reviewer Joe McDonnell.
--
To view, visit http://gerrit.cloudera.org:8080/13718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ifd7716d5d5ccc4b2f79b3acf2fbc880716b4c0fe
Gerrit-Change-Number: 13718
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8565: larger query in test admission controller
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13718 )
Change subject: IMPALA-8565: larger query in test_admission_controller
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3730/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd7716d5d5ccc4b2f79b3acf2fbc880716b4c0fe
Gerrit-Change-Number: 13718
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 00:30:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8565: larger query in test admission controller
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13718 )
Change subject: IMPALA-8565: larger query in test_admission_controller
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd7716d5d5ccc4b2f79b3acf2fbc880716b4c0fe
Gerrit-Change-Number: 13718
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 11:03:10 +0000
Gerrit-HasComments: No