[GitHub] [spark] tgravescs commented on a change in pull request #29869: [SPARK-32994][CORE] Update external heavy accumulators before they entering into listener event loop

[GitBox <gi...@apache.org>]

tgravescs commented on a change in pull request #29869:
URL: https://github.com/apache/spark/pull/29869#discussion_r497698446



##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -274,8 +274,36 @@ private[spark] class DAGScheduler(
       accumUpdates: Seq[AccumulatorV2[_, _]],
       metricPeaks: Array[Long],
       taskInfo: TaskInfo): Unit = {
+    // It may cause heavy full GC problem if some heavy external accumulators keep in memory.
+    // We update these heavy accumulators before they entering into Spark listener event loop.
+    val (heavyAccumUpdates, otherAccumUpdates) = accumUpdates.partition { acc =>

Review comment:
       internal configs and user facing are completely different.  Yes if someone reads the code they could create internal ones but that is use at your own risk and we don't guarantee any api. This is user facing api essentially.  I agree with @maropu I'm not really fond of the prefix approach.   Is this only for CollectionAccumulator or SetAccumulator? Although it looks like the SetAccumulator is specific to delta.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org