You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/17 04:08:52 UTC
[GitHub] [incubator-doris] acelyc111 opened a new pull request #3128:
[Thrift] Fix a bug when ThriftClientImpl close() error
acelyc111 opened a new pull request #3128: [Thrift] Fix a bug when ThriftClientImpl close() error
URL: https://github.com/apache/incubator-doris/pull/3128
In ThriftClientImpl close(), the under layer TTransport may throw an exception,
this pathch catch the exception to avoid crash.
issue: https://github.com/apache/incubator-doris/issues/3126
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #3128: [Thrift] Fix a
bug when ThriftClientImpl close() error
Posted by GitBox <gi...@apache.org>.
imay merged pull request #3128: [Thrift] Fix a bug when ThriftClientImpl close() error
URL: https://github.com/apache/incubator-doris/pull/3128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #3128:
[Thrift] Fix a bug when ThriftClientImpl close() error
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3128: [Thrift] Fix a bug when ThriftClientImpl close() error
URL: https://github.com/apache/incubator-doris/pull/3128#discussion_r393439371
##########
File path: be/src/util/thrift_client.cpp
##########
@@ -65,12 +76,21 @@ Status ThriftClientImpl::open_with_retry(int num_tries, int wait_ms) {
return status;
}
-Status ThriftClientImpl::close() {
- if (_transport->isOpen()) {
- _transport->close();
+void ThriftClientImpl::close() {
+ try {
+ if (_transport.get() != NULL && _transport->isOpen()) _transport->close();
Review comment:
prefer nullptr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on issue #3128: [Thrift] Fix
a bug when ThriftClientImpl close() error
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on issue #3128: [Thrift] Fix a bug when ThriftClientImpl close() error
URL: https://github.com/apache/incubator-doris/pull/3128#issuecomment-599867774
The modification has referenced to Impala, https://github.com/apache/impala/blob/master/be/src/rpc/thrift-client.cc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org