You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/13 07:03:51 UTC
[GitHub] [airflow] mik-laj opened a new pull request #10312: Add guide about custom API authentication
mik-laj opened a new pull request #10312:
URL: https://github.com/apache/airflow/pull/10312
Close: https://github.com/apache/airflow/issues/8123
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #10312: Add guide about custom API authentication
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #10312:
URL: https://github.com/apache/airflow/pull/10312#discussion_r470864155
##########
File path: docs/security.rst
##########
@@ -160,6 +160,24 @@ look like the following.
-H 'Cache-Control: no-cache' \
-H "Authorization: Bearer ${ID_TOKEN}"
+Roll your own API authentication
+''''''''''''''''''''''''''''''''
+
+Each auth backend is defined as a new Python module. It must have 2 defined methods:
+
+* ``init_app(app: Flask)`` - function invoked when creating a flash application, which allows you to add a new view.
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #10312: Add guide about custom API authentication
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #10312:
URL: https://github.com/apache/airflow/pull/10312#discussion_r470861817
##########
File path: docs/security.rst
##########
@@ -160,6 +160,24 @@ look like the following.
-H 'Cache-Control: no-cache' \
-H "Authorization: Bearer ${ID_TOKEN}"
+Roll your own API authentication
+''''''''''''''''''''''''''''''''
+
+Each auth backend is defined as a new Python module. It must have 2 defined methods:
Review comment:
```suggestion
Each auth backend should be defined as a new Python module. It must have 2 defined methods:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #10312: Add guide about custom API authentication
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #10312:
URL: https://github.com/apache/airflow/pull/10312#discussion_r470861817
##########
File path: docs/security.rst
##########
@@ -160,6 +160,24 @@ look like the following.
-H 'Cache-Control: no-cache' \
-H "Authorization: Bearer ${ID_TOKEN}"
+Roll your own API authentication
+''''''''''''''''''''''''''''''''
+
+Each auth backend is defined as a new Python module. It must have 2 defined methods:
Review comment:
```suggestion
Each auth backend should be defined as a new Python module. It must have 2 defined methods:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #10312: Add guide about custom API authentication
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #10312:
URL: https://github.com/apache/airflow/pull/10312#discussion_r470862008
##########
File path: docs/security.rst
##########
@@ -160,6 +160,24 @@ look like the following.
-H 'Cache-Control: no-cache' \
-H "Authorization: Bearer ${ID_TOKEN}"
+Roll your own API authentication
+''''''''''''''''''''''''''''''''
+
+Each auth backend is defined as a new Python module. It must have 2 defined methods:
+
+* ``init_app(app: Flask)`` - function invoked when creating a flash application, which allows you to add a new view.
Review comment:
```suggestion
* ``init_app(app: Flask)`` - function invoked when creating a flask application, which allows you to add a new view.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #10312: Add guide about custom API authentication
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #10312:
URL: https://github.com/apache/airflow/pull/10312
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10312: Add guide about custom API authentication
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10312:
URL: https://github.com/apache/airflow/pull/10312#issuecomment-673301916
CC: @jhtimmins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org