You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by li...@apache.org on 2020/07/13 01:29:33 UTC

[submarine] branch master updated: SUBMARINE-563. Liveness probe failed in notebook-controller pod

This is an automated email from the ASF dual-hosted git repository.

liuxun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new 2252992  SUBMARINE-563. Liveness probe failed in notebook-controller pod
2252992 is described below

commit 225299299e6c8cd790d092ad03041f6af1401a82
Author: Ryan Lo <lo...@gmail.com>
AuthorDate: Sun Jul 12 13:21:23 2020 +0000

    SUBMARINE-563. Liveness probe failed in notebook-controller pod
    
    ### What is this PR for?
    Liveness probe failure will happen in notebook-controller pod if using helm chart install submarine.
    This PR will solve the problem.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    [SUBMARINE-563](https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-563)
    
    ### How should this be tested?
    [Travis CI](https://travis-ci.org/github/lowc1012/submarine/builds/707358205)
    
    ### Screenshots (if appropriate)
    <img width="1154" alt="image1" src="https://user-images.githubusercontent.com/52355146/87247707-04011e80-c488-11ea-935c-4ae4bfa6a865.png">
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Ryan Lo <lo...@gmail.com>
    
    Closes #345 from lowc1012/SUBMARINE-563 and squashes the following commits:
    
    95ba1d4 [Ryan Lo] SUBMARINE-563. Liveness probe failed in notebook-controller pod
---
 .../charts/notebook-controller/templates/cluster-role-binding.yaml      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/helm-charts/submarine/charts/notebook-controller/templates/cluster-role-binding.yaml b/helm-charts/submarine/charts/notebook-controller/templates/cluster-role-binding.yaml
index f06b165..1e4180f 100644
--- a/helm-charts/submarine/charts/notebook-controller/templates/cluster-role-binding.yaml
+++ b/helm-charts/submarine/charts/notebook-controller/templates/cluster-role-binding.yaml
@@ -23,7 +23,7 @@ metadata:
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
-  name: role
+  name: notebook-controller-role
 subjects:
 - kind: ServiceAccount
   name: notebook-controller-service-account


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org