[jira] [Commented] (CASSANDRA-8616) sstable tools may result in commit log segments be written

["Yuki Morishita (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-8616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485375#comment-15485375 ] 

Yuki Morishita commented on CASSANDRA-8616:
-------------------------------------------

I took another approach in the new patches.
Since the source of accessing commit log is {{Memtable}}, I changed {{Tracker}} to have {{Memtable}} optional when only on online. (This change may also be useful for future offline tools change.)

There are several places that try to update system tables (sstable_activity, secondary index, compaction) so I manually had to disabled them by checking {{DatabaseDescriptor.isDaemonInitialized}} (in trunk, added similar method to 2.2 and 3.0), or offline tool can hang.

||branch||testall||dtest||
|[8616-2.2|https://github.com/yukim/cassandra/tree/8616-2.2]|[testall|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-8616-2.2-testall/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-8616-2.2-dtest/lastCompletedBuild/testReport/]|
|[8616-3.0|https://github.com/yukim/cassandra/tree/8616-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-8616-3.0-testall/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-8616-3.0-dtest/lastCompletedBuild/testReport/]|
|[8616-trunk|https://github.com/yukim/cassandra/tree/8616-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-8616-trunk-testall/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-8616-trunk-dtest/lastCompletedBuild/testReport/]|

(test is still running for some)

> sstable tools may result in commit log segments be written
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-8616
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8616
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Tyler Hobbs
>            Assignee: Yuki Morishita
>             Fix For: 2.1.x, 2.2.x, 3.0.x, 3.x
>
>         Attachments: 8161-2.0.txt
>
>
> There was a report of sstable2json causing commitlog segments to be written out when run.  I haven't attempted to reproduce this yet, so that's all I know for now.  Since sstable2json loads the conf and schema, I'm thinking that it may inadvertently be triggering the commitlog code.
> sstablescrub, sstableverify, and other sstable tools have the same issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)