[GitHub] [solr] HoustonPutman commented on a change in pull request #595: SOLR-15982: Add end time value to backup response

[GitBox <gi...@apache.org>]

HoustonPutman commented on a change in pull request #595:
URL: https://github.com/apache/solr/pull/595#discussion_r806052548



##########
File path: solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc
##########
@@ -104,6 +104,44 @@ All the usages are replaced by BaseHttpSolrClient.RemoteSolrException and BaseHt
 In previous versions there was a field returned in async backup status responses, `Response`. This has now been renamed to `msg`, to better fit other collections API responses.
 The `response` field is now a map, containing information about the backup (`startTime`, `indexSizeMB`, `indexFileCount`, etc.).
 
+* SOLR-15982: For collection's snapshot backup request responses additional fields `indexVersion`, `indexFileCount`, etc. were added similar to incremental backup request responses. Also, both snapshot and incremental backup request responses will now contain `starTime` and `endTime`. Here is an example of how collection's snapshot backup request responses will looks like:
+
+Incremental:
+
+```json
+"response": {
+    "collection": "techproducts",
+    "numShards": 2,
+    "backupId": 0,
+    "indexVersion": "9.0.0",
+    "startTime": "2022-02-11T17:20:44.157305500Z",
+    "indexFileCount": 22,
+    "uploadedIndexFileCount": 22,
+    "indexSizeMB": 0.007,
+    "uploadedIndexFileMB": 0.007,
+    "shardBackupIds": [
+        "md_shard2_0",
+        "md_shard1_0"
+    ],
+    "endTime": "2022-02-11T17:20:45.245534400Z"
+}
+```
+
+Snapshot:
+
+```json
+"response": {
+    "collection": "techproducts",
+    "numShards": 2,
+    "indexVersion": "9.0.0",
+    "startTime": "2022-02-11T17:19:33.271461700Z",
+    "indexFileCount": 22,
+    "endTime": "2022-02-11T17:19:34.363859100Z"
+}
+```

Review comment:
       I agree that this is too much for the major changes page. I think you can add it to the collections api entry if you want, and style it like this: https://solr.apache.org/guide/8_11/collections-api.html#examples-of-async-requests, but it's not a requirement for this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org