You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Rafael Schloming <ra...@redhat.com> on 2010/02/02 22:23:34 UTC
moving stuff out of the python dir
Some of you may recall that I ranted a bit just prior to the freeze for
the 0.6 release about how lots of non-client related stuff has been
accumulating in the python directory as of late. It was a bit too late
to do anything about it at the time, but as the freeze is over now, I'd
like to start cleaning things up a bit.
For that reason I intend to make the following moves over the next few
days. Please shout if this will disrupt you or if you disagree with any
of the locations I've picked.
These are the files currently under qpid/python:
Makefile
LICENSE.txt
NOTICE.txt
README.txt
RELEASE_NOTES
todo.txt
commands/ ---> qpid/tools
doc/
examples/
mllib/ ---> qpid/extras/mllib
models/ ---> qpid/sandbox/models
preppy
qmf/ ---> qpid/extras/qmf
qmf2/ ---> qpid/extras/qmf
qpid/
qpid-python-test
qpid_config.py
setup.py
tests/
tests_0-10/ ---> qpid/tests/amqp_0-10
tests_0-8/ ---> qpid/tests/amqp_0-8
tests_0-9/ ---> qpid/tests/amqp_0-9
--Rafael
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: moving stuff out of the python dir
Posted by Rajith Attapattu <ra...@gmail.com>.
On Wed, Feb 3, 2010 at 7:16 AM, Rafael Schloming <ra...@redhat.com> wrote:
> Rajith Attapattu wrote:
>>
>> On Tue, Feb 2, 2010 at 4:23 PM, Rafael Schloming <ra...@redhat.com>
>> wrote:
>>>
>>> Some of you may recall that I ranted a bit just prior to the freeze for
>>> the
>>> 0.6 release about how lots of non-client related stuff has been
>>> accumulating
>>> in the python directory as of late. It was a bit too late to do anything
>>> about it at the time, but as the freeze is over now, I'd like to start
>>> cleaning things up a bit.
>>>
>>> For that reason I intend to make the following moves over the next few
>>> days.
>>> Please shout if this will disrupt you or if you disagree with any of the
>>> locations I've picked.
>>
>> Instead of the following
>> qmf/ ---> qpid/extras/qmf
>> qmf2/ ---> qpid/extras/qmf
>>
>> How about,
>>
>> qmf/ ---> qpid/management/qmf
>> qmf2/ ---> qpid/management/qmf
>
> I wouldn't consider qmf a management tool. It's really a general purpose
> remoting library that happens to be used by us to build management tools,
> but may well be used for non management things.
>
> Also, I'm not sure there is necessarily a need to distinguish between
> "management" and "tools". There seems to be a potential for overlap there
> between e.g. diagnostic tools and management tools, but maybe I'm missing
> some distinction you're thinking of?
I am fine with qmf stuff being under tools.
>> Ideally I'd like to see the following top level directories
>>
>> management
>> brokers
>> clients
>> tools
>> extras
>> docs
>> tests
>> sandbox
>>
>> Getting there might be a challenge, but we will eventually get there
>> if we do it step by step.
>
> Other than management and tools seeming a bit redundant/overlapping, I like
> this organization, however I don't really want to get mired in a big reorg
> discussion. Right now I'm just focusing on cleaning up the situation in the
> python dir.
If are to get there I think the key is to not initiate any big reorg,
but rather changes like what you are doing for the python dir.
If people take the initiative and make minor changes like this, then
over a period of time we will eventually get there.
> --Rafael
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
--
Regards,
Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: moving stuff out of the python dir
Posted by Rafael Schloming <ra...@redhat.com>.
Rajith Attapattu wrote:
> On Tue, Feb 2, 2010 at 4:23 PM, Rafael Schloming <ra...@redhat.com> wrote:
>> Some of you may recall that I ranted a bit just prior to the freeze for the
>> 0.6 release about how lots of non-client related stuff has been accumulating
>> in the python directory as of late. It was a bit too late to do anything
>> about it at the time, but as the freeze is over now, I'd like to start
>> cleaning things up a bit.
>>
>> For that reason I intend to make the following moves over the next few days.
>> Please shout if this will disrupt you or if you disagree with any of the
>> locations I've picked.
> Instead of the following
> qmf/ ---> qpid/extras/qmf
> qmf2/ ---> qpid/extras/qmf
>
> How about,
>
> qmf/ ---> qpid/management/qmf
> qmf2/ ---> qpid/management/qmf
I wouldn't consider qmf a management tool. It's really a general purpose
remoting library that happens to be used by us to build management
tools, but may well be used for non management things.
Also, I'm not sure there is necessarily a need to distinguish between
"management" and "tools". There seems to be a potential for overlap
there between e.g. diagnostic tools and management tools, but maybe I'm
missing some distinction you're thinking of?
> Ideally I'd like to see the following top level directories
>
> management
> brokers
> clients
> tools
> extras
> docs
> tests
> sandbox
>
> Getting there might be a challenge, but we will eventually get there
> if we do it step by step.
Other than management and tools seeming a bit redundant/overlapping, I
like this organization, however I don't really want to get mired in a
big reorg discussion. Right now I'm just focusing on cleaning up the
situation in the python dir.
--Rafael
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: moving stuff out of the python dir
Posted by Rajith Attapattu <ra...@gmail.com>.
On Tue, Feb 2, 2010 at 4:23 PM, Rafael Schloming <ra...@redhat.com> wrote:
> Some of you may recall that I ranted a bit just prior to the freeze for the
> 0.6 release about how lots of non-client related stuff has been accumulating
> in the python directory as of late. It was a bit too late to do anything
> about it at the time, but as the freeze is over now, I'd like to start
> cleaning things up a bit.
>
> For that reason I intend to make the following moves over the next few days.
> Please shout if this will disrupt you or if you disagree with any of the
> locations I've picked.
Instead of the following
qmf/ ---> qpid/extras/qmf
qmf2/ ---> qpid/extras/qmf
How about,
qmf/ ---> qpid/management/qmf
qmf2/ ---> qpid/management/qmf
Ideally I'd like to see the following top level directories
management
brokers
clients
tools
extras
docs
tests
sandbox
Getting there might be a challenge, but we will eventually get there
if we do it step by step.
> These are the files currently under qpid/python:
>
> Makefile
> LICENSE.txt
> NOTICE.txt
> README.txt
> RELEASE_NOTES
> todo.txt
> commands/ ---> qpid/tools
> doc/
> examples/
> mllib/ ---> qpid/extras/mllib
> models/ ---> qpid/sandbox/models
> preppy
> qmf/ ---> qpid/extras/qmf
> qmf2/ ---> qpid/extras/qmf
> qpid/
> qpid-python-test
> qpid_config.py
> setup.py
> tests/
> tests_0-10/ ---> qpid/tests/amqp_0-10
> tests_0-8/ ---> qpid/tests/amqp_0-8
> tests_0-9/ ---> qpid/tests/amqp_0-9
>
> --Rafael
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
--
Regards,
Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: moving stuff out of the python dir
Posted by Rafael Schloming <ra...@redhat.com>.
Alan Conway wrote:
> On 02/02/2010 04:23 PM, Rafael Schloming wrote:
>> Some of you may recall that I ranted a bit just prior to the freeze for
>> the 0.6 release about how lots of non-client related stuff has been
>> accumulating in the python directory as of late. It was a bit too late
>> to do anything about it at the time, but as the freeze is over now, I'd
>> like to start cleaning things up a bit.
>>
>> For that reason I intend to make the following moves over the next few
>> days. Please shout if this will disrupt you or if you disagree with any
>> of the locations I've picked.
>>
>> These are the files currently under qpid/python:
>>
>> Makefile
>> LICENSE.txt
>> NOTICE.txt
>> README.txt
>> RELEASE_NOTES
>> todo.txt
>> commands/ ---> qpid/tools
>> doc/
>> examples/
>> mllib/ ---> qpid/extras/mllib
>> models/ ---> qpid/sandbox/models
>> preppy
>> qmf/ ---> qpid/extras/qmf
>> qmf2/ ---> qpid/extras/qmf
>> qpid/
>> qpid-python-test
>> qpid_config.py
>> setup.py
>> tests/
>> tests_0-10/ ---> qpid/tests/amqp_0-10
>> tests_0-8/ ---> qpid/tests/amqp_0-8
>> tests_0-9/ ---> qpid/tests/amqp_0-9
>>
>
> Do you still want to move qpid/brokertest.py out of the python dir?
> Would that move to tests/qpid?
> I'll need to update some scripts in the cpp tree if/when that moves.
I do still want to move that somewhere, although I'm not sure where.
I'll give you a heads up before I do anything with that and I'll make
sure the cpp build & tests are in order.
One thing I've realized in futzing with this a bit is that you can't
actually have multiple independently installable packages with the same
top level name in python, e.g. my plan of having the python client under
qpid.* and the protocol tests under qpid.broker_0-* needs to be slightly
further amended in some way so that the two qpid packages won't conflict.
--Rafael
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: moving stuff out of the python dir
Posted by Alan Conway <ac...@redhat.com>.
On 02/02/2010 04:23 PM, Rafael Schloming wrote:
> Some of you may recall that I ranted a bit just prior to the freeze for
> the 0.6 release about how lots of non-client related stuff has been
> accumulating in the python directory as of late. It was a bit too late
> to do anything about it at the time, but as the freeze is over now, I'd
> like to start cleaning things up a bit.
>
> For that reason I intend to make the following moves over the next few
> days. Please shout if this will disrupt you or if you disagree with any
> of the locations I've picked.
>
> These are the files currently under qpid/python:
>
> Makefile
> LICENSE.txt
> NOTICE.txt
> README.txt
> RELEASE_NOTES
> todo.txt
> commands/ ---> qpid/tools
> doc/
> examples/
> mllib/ ---> qpid/extras/mllib
> models/ ---> qpid/sandbox/models
> preppy
> qmf/ ---> qpid/extras/qmf
> qmf2/ ---> qpid/extras/qmf
> qpid/
> qpid-python-test
> qpid_config.py
> setup.py
> tests/
> tests_0-10/ ---> qpid/tests/amqp_0-10
> tests_0-8/ ---> qpid/tests/amqp_0-8
> tests_0-9/ ---> qpid/tests/amqp_0-9
>
Do you still want to move qpid/brokertest.py out of the python dir? Would that
move to tests/qpid?
I'll need to update some scripts in the cpp tree if/when that moves.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: moving stuff out of the python dir
Posted by Rafael Schloming <ra...@redhat.com>.
Ken Giusti wrote:
> Ah, yes - I see now. I'm ok with extras/qmf/qmf[2], but that begs the question - what about non-python QMF stuff, like other language bindings and cross-implementation interopt tests?
>
> If we end up moving all qmf-related stuff into extras, then we'd probably need flesh out a bit more structure for that qmf subdir. e.g.:
>
> extras/qmf/python/{qmf, qmf2, tests, ...}
> extras/qmf/cpp/{...}
> extras/qmf/bindings/{....}
> extras/qmf/tests/{...}
>
> Thoughts?
My initial thought was to just to move the qmf library into it's own
directory and let that evolve from there on its own.
Something like the above makes sense, one thing I've been considering
doing for the python client that may make sense here as well is to
introduce a src dir. This especially makes sense if you want c/cpp
modules/bindings/etc alongside the python code, e.g.:
extras/qmf/src/cpp/...
extras/qmf/src/py/...
--Rafael
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: moving stuff out of the python dir
Posted by Ken Giusti <kg...@redhat.com>.
Ah, yes - I see now. I'm ok with extras/qmf/qmf[2], but that begs the question - what about non-python QMF stuff, like other language bindings and cross-implementation interopt tests?
If we end up moving all qmf-related stuff into extras, then we'd probably need flesh out a bit more structure for that qmf subdir. e.g.:
extras/qmf/python/{qmf, qmf2, tests, ...}
extras/qmf/cpp/{...}
extras/qmf/bindings/{....}
extras/qmf/tests/{...}
Thoughts?
-K
----- "Rafael Schloming" <ra...@redhat.com> wrote:
> Ken Giusti wrote:
> > Hi,
> >
> > I've no problem with a cleanup reorg, but I'd like to keep the qmf
> version in the dirname (wherever it may end up). e.g.:
> >
> >>> qmf/ ---> qpid/extras/qmf/
> >>> qmf2/ ---> qpid/extras/qmf2/
>
> Ah, I was a bit unclear in my notation, I was thinking of
> qpid/extras/qmf/qmf, and qpid/extras/qmf/qmf2, assuming that they
> would
> share license, install, and packaging bits, but I'd be happy to do it
> as
> above as well if you wanted qmf and qmf2 to be separate directories
> within extras.
>
> --Rafael
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: moving stuff out of the python dir
Posted by Rafael Schloming <ra...@redhat.com>.
Ken Giusti wrote:
> Hi,
>
> I've no problem with a cleanup reorg, but I'd like to keep the qmf version in the dirname (wherever it may end up). e.g.:
>
>>> qmf/ ---> qpid/extras/qmf/
>>> qmf2/ ---> qpid/extras/qmf2/
Ah, I was a bit unclear in my notation, I was thinking of
qpid/extras/qmf/qmf, and qpid/extras/qmf/qmf2, assuming that they would
share license, install, and packaging bits, but I'd be happy to do it as
above as well if you wanted qmf and qmf2 to be separate directories
within extras.
--Rafael
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: moving stuff out of the python dir
Posted by Ken Giusti <kg...@redhat.com>.
Hi,
I've no problem with a cleanup reorg, but I'd like to keep the qmf version in the dirname (wherever it may end up). e.g.:
> > qmf/ ---> qpid/extras/qmf/
> > qmf2/ ---> qpid/extras/qmf2/
thanks,
-K
----- "Rafael Schloming" <ra...@redhat.com> wrote:
> Rafael Schloming wrote:
> > Some of you may recall that I ranted a bit just prior to the freeze
> for
> > the 0.6 release about how lots of non-client related stuff has been
>
> > accumulating in the python directory as of late. It was a bit too
> late
> > to do anything about it at the time, but as the freeze is over now,
> I'd
> > like to start cleaning things up a bit.
> >
> > For that reason I intend to make the following moves over the next
> few
> > days. Please shout if this will disrupt you or if you disagree with
> any
> > of the locations I've picked.
> >
> > These are the files currently under qpid/python:
> >
> > Makefile
> > LICENSE.txt
> > NOTICE.txt
> > README.txt
> > RELEASE_NOTES
> > todo.txt
> > commands/ ---> qpid/tools
> > doc/
> > examples/
> > mllib/ ---> qpid/extras/mllib
> > models/ ---> qpid/sandbox/models
> > preppy
> > qmf/ ---> qpid/extras/qmf
> > qmf2/ ---> qpid/extras/qmf
> > qpid/
> > qpid-python-test
> > qpid_config.py
> > setup.py
> > tests/
> > tests_0-10/ ---> qpid/tests/amqp_0-10
> > tests_0-8/ ---> qpid/tests/amqp_0-8
> > tests_0-9/ ---> qpid/tests/amqp_0-9
>
> On second thought, I think perhaps moving the tests as below may be
> better. This will result in a python package structure that puts them
> in
> the qpid namespace which will allow them to be installed, as well as
> replacing "-" with "_" which will allow normal imports:
>
> tests_0-10/ ---> qpid/tests/amqp/qpid/broker_0_10
> tests_0-8/ ---> qpid/tests/amqp/qpid/broker_0_8
> tests_0-9/ ---> qpid/tests/amqp/qpid/broker_0_9
>
> --Rafael
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: moving stuff out of the python dir
Posted by Rafael Schloming <ra...@redhat.com>.
Rafael Schloming wrote:
> Some of you may recall that I ranted a bit just prior to the freeze for
> the 0.6 release about how lots of non-client related stuff has been
> accumulating in the python directory as of late. It was a bit too late
> to do anything about it at the time, but as the freeze is over now, I'd
> like to start cleaning things up a bit.
>
> For that reason I intend to make the following moves over the next few
> days. Please shout if this will disrupt you or if you disagree with any
> of the locations I've picked.
>
> These are the files currently under qpid/python:
>
> Makefile
> LICENSE.txt
> NOTICE.txt
> README.txt
> RELEASE_NOTES
> todo.txt
> commands/ ---> qpid/tools
> doc/
> examples/
> mllib/ ---> qpid/extras/mllib
> models/ ---> qpid/sandbox/models
> preppy
> qmf/ ---> qpid/extras/qmf
> qmf2/ ---> qpid/extras/qmf
> qpid/
> qpid-python-test
> qpid_config.py
> setup.py
> tests/
> tests_0-10/ ---> qpid/tests/amqp_0-10
> tests_0-8/ ---> qpid/tests/amqp_0-8
> tests_0-9/ ---> qpid/tests/amqp_0-9
On second thought, I think perhaps moving the tests as below may be
better. This will result in a python package structure that puts them in
the qpid namespace which will allow them to be installed, as well as
replacing "-" with "_" which will allow normal imports:
tests_0-10/ ---> qpid/tests/amqp/qpid/broker_0_10
tests_0-8/ ---> qpid/tests/amqp/qpid/broker_0_8
tests_0-9/ ---> qpid/tests/amqp/qpid/broker_0_9
--Rafael
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org