You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2026/02/18 07:14:37 UTC
[PR] chore(deps-dev): bump timezone-mock from 1.4.0 to 1.4.2 in /superset-frontend [superset]
dependabot[bot] opened a new pull request, #38049:
URL: https://github.com/apache/superset/pull/38049
Bumps [timezone-mock](https://github.com/Jimbly/timezone-mock) from 1.4.0 to 1.4.2.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/Jimbly/timezone-mock/commits">compare view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by [GitHub Actions](<a href="https://www.npmjs.com/~GitHub">https://www.npmjs.com/~GitHub</a> Actions), a new releaser for timezone-mock since your current version.</p>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): bump timezone-mock from 1.4.0 to 1.4.2 in /superset-frontend [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #38049:
URL: https://github.com/apache/superset/pull/38049#issuecomment-4174760325
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): bump timezone-mock from 1.4.0 to 1.4.2 in /superset-frontend [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #38049:
URL: https://github.com/apache/superset/pull/38049#issuecomment-4275694056
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/38049?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.49%. Comparing base ([`fca64de`](https://app.codecov.io/gh/apache/superset/commit/fca64de8e94b57629efcbeedc6e46ee1c4ab0ca3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3acb95f`](https://app.codecov.io/gh/apache/superset/commit/3acb95f54019427cea71420e0fa0643d0df74e05?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #38049 +/- ##
=======================================
Coverage 64.49% 64.49%
=======================================
Files 2557 2557
Lines 133191 133191
Branches 30935 30935
=======================================
Hits 85897 85897
Misses 45804 45804
Partials 1490 1490
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/38049/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/38049/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.32% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/38049?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): bump timezone-mock from 1.4.0 to 1.4.2 in /superset-frontend [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38049:
URL: https://github.com/apache/superset/pull/38049#issuecomment-4275735570
**Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): bump timezone-mock from 1.4.0 to 1.4.2 in /superset-frontend [superset]
Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] commented on PR #38049:
URL: https://github.com/apache/superset/pull/38049#issuecomment-4174760575
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!
If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): bump timezone-mock from 1.4.0 to 1.4.2 in /superset-frontend [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #38049:
URL: https://github.com/apache/superset/pull/38049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): bump timezone-mock from 1.4.0 to 1.4.2 in /superset-frontend [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #38049:
URL: https://github.com/apache/superset/pull/38049#issuecomment-4275632064
This was tricky for non-timezone folks like me but the issue was due to new `timezone-mock` behavior, namely [a fix to ensure mock timezone's offset to be used instead system timezone's offset, which is already mocked by Jest](https://github.com/Jimbly/timezone-mock/commit/95f7e648540ec454f20c6cab869a32f68c04b617#diff-334bf269ae4f257c9efdadc31d90969b23fff7da106248f57e085a60aa6aec4b).
Since the dep is for development only, we only need green CI and brace ourselves for any behavior change in future `timezone-mock`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): bump timezone-mock from 1.4.0 to 1.4.2 in /superset-frontend [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38049:
URL: https://github.com/apache/superset/pull/38049#issuecomment-3919122078
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): bump timezone-mock from 1.4.0 to 1.4.2 in /superset-frontend [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #38049:
URL: https://github.com/apache/superset/pull/38049#issuecomment-4181908146
## Dependabot Review: CI Failing — Tests Broken by timezone-mock Change
**CI Status:** 2 failures in `sharded-jest-tests (1)` and `sharded-jest-tests (2)`
**Root Cause:** The bump from `timezone-mock@1.4.0` to `1.4.2` breaks tests in `packages/superset-ui-core/test/time-comparison/parseDttmToDate.test.ts`. All date-parsing tests using timezone mocking are failing (15+ individual test cases including 'today', 'Last day', 'Last week', 'Last month', etc.).
This is a **real regression** caused by the dependency change — `timezone-mock` changed behavior in how it mocks timezones, causing these tests to receive unexpected date values.
**Breaking Changes:** `timezone-mock@1.4.2` contains a behavioral change in timezone simulation that affects date calculation assertions.
**Fix Required:**
1. Review the [timezone-mock changelog](https://github.com/nicedoc/timezone-mock/blob/master/CHANGELOG.md) for what changed in 1.4.1 and 1.4.2
2. Update the test file `packages/superset-ui-core/test/time-comparison/parseDttmToDate.test.ts` to match the new behavior OR pin back to 1.4.0 if the new behavior is incorrect
3. Related PR #38042 has the same issue in `superset-frontend/packages/superset-ui-core`
**Recommendation:** Do NOT merge until the test failures are resolved. Investigate whether the new timezone-mock behavior is correct or a regression in the library itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org