You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2019/02/21 16:39:41 UTC

[GitHub] coheigea commented on a change in pull request #515: FileUtils: move test specific getStringFromFile; remove extra space

coheigea commented on a change in pull request #515: FileUtils: move test specific getStringFromFile; remove extra space
URL: https://github.com/apache/cxf/pull/515#discussion_r259013351
 
 

 ##########
 File path: core/src/main/java/org/apache/cxf/helpers/FileUtils.java
 ##########
 @@ -293,67 +290,6 @@ public static File createTempFile(String prefix, String suffix, File parentDir,
         return result;
     }
 
-    public static String getStringFromFile(File location) {
 
 Review comment:
   I'm not sure if it's wise to be removing public methods for a minor patch, maybe we should wait until we move to 3.4.0-SNAPSHOT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services