You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/31 14:03:54 UTC

[GitHub] [skywalking-eyes] kezhenxu94 opened a new pull request #17: Finalize 0.1, fix a minor bug, add docs, etc.

kezhenxu94 opened a new pull request #17:
URL: https://github.com/apache/skywalking-eyes/pull/17


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-eyes] kezhenxu94 commented on a change in pull request #17: Finalize 0.1, fix a minor bug, add docs, etc.

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-eyes/pull/17#discussion_r550489764



##########
File path: README.md
##########
@@ -41,9 +41,7 @@ header:
 
 **NOTE**: The full configurations can be found in [the configuration section](#configurations).
 
-### Use as a Binary
-
-#### Install
+### Compile from Source

Review comment:
       We will have another 2 sections: "Use with Docker image", "Use as a Binary" after we have the release binary and docker image




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-eyes] wu-sheng commented on a change in pull request #17: Finalize 0.1, fix a minor bug, add docs, etc.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-eyes/pull/17#discussion_r550492350



##########
File path: CHANGES.md
##########
@@ -4,3 +4,7 @@
   + Add `check` and `fix` command.
   + `check` results can be reported to pull request as comments.
   + `fix` suggestions can be filed on pull request as edit suggestions.
+
+- Dependencies License Report
+  + Support Golang `go.mod` dependency report.
+  + Licences Apache 2.0, BSD-3-Clause and MIT can be identified.

Review comment:
       I prefer to skip the unstable features.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-eyes] wu-sheng merged pull request #17: Finalize 0.1, fix a minor bug, add docs, etc.

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #17:
URL: https://github.com/apache/skywalking-eyes/pull/17


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-eyes] kezhenxu94 commented on a change in pull request #17: Finalize 0.1, fix a minor bug, add docs, etc.

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-eyes/pull/17#discussion_r550490348



##########
File path: CHANGES.md
##########
@@ -4,3 +4,7 @@
   + Add `check` and `fix` command.
   + `check` results can be reported to pull request as comments.
   + `fix` suggestions can be filed on pull request as edit suggestions.
+
+- Dependencies License Report
+  + Support Golang `go.mod` dependency report.
+  + Licences Apache 2.0, BSD-3-Clause and MIT can be identified.

Review comment:
       Also want to ask for @wu-sheng your opinion on, whether we want to include this "Dependencies License Report" in the first version, or just don't mention this in the change log until we have more complete supported list of languages / licenses, maybe next version?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org