You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/22 21:12:24 UTC

[GitHub] [airflow] ashb opened a new pull request, #28543: Emit warnings for `conf.get*` from the right source location

ashb opened a new pull request, #28543:
URL: https://github.com/apache/airflow/pull/28543

   `getboolean` and other typed get functions were issuing warnings from
   "inside" themselves.
   
   Before:
   
   ```
   $ python ./airflow/airflow/kubernetes/kube_client.py
   /home/ash/code/airflow/airflow/airflow/configuration.py:722 DeprecationWarning: The in_cluster option in [kubernetes] has been moved to the in_cluster option in [kubernetes_executor] - the old setting has been used, but please update your config.
   ```
   
   After:
   
   ```
   $ python ./airflow/airflow/kubernetes/kube_client.py
   /home/ash/code/airflow/airflow/airflow/kubernetes/kube_client.py:89 DeprecationWarning: The in_cluster option in [kubernetes] has been moved to the in_cluster option in [kubernetes_executor] - the old setting has been used, but please update your config.
   ```
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #28543: Emit warnings for `conf.get*` from the right source location

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #28543:
URL: https://github.com/apache/airflow/pull/28543#issuecomment-1363777801

   I thought about maybe combining the emit_warnings and extra_stacklevel in to a single parameter


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #28543: Emit warnings for `conf.get*` from the right source location

Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #28543:
URL: https://github.com/apache/airflow/pull/28543#issuecomment-1365704357

   Answer is no, since frame information is resolved eagerly during `warning.warn()`, and the original information is dropped immediately.
   
   We could probably still come up with some wrapper, but I guess it’s less worthwhile.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #28543: Emit warnings for `conf.get*` from the right source location

Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #28543:
URL: https://github.com/apache/airflow/pull/28543#issuecomment-1365670342

   I wonder if there’s some decorator magic to do something like
   
   ```python
   with increse_warning_stacklevel(FutureWarning, stacklevel=2):
       self.get(section, key)
   ```
   
   This would be cleaner than passing in an additional argument.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb merged pull request #28543: Emit warnings for `conf.get*` from the right source location

Posted by GitBox <gi...@apache.org>.
ashb merged PR #28543:
URL: https://github.com/apache/airflow/pull/28543


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org