You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by cheng xu <ch...@intel.com> on 2015/06/02 05:40:33 UTC
Review Request 34922: HIVE-10705 Update tests for HIVE-9302 after
removing binaries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34922/
-----------------------------------------------------------
Review request for hive, Hari Sankar Sivarama Subramaniyan, Sushanth Sowmyan, and Vaibhav Gumashta.
Bugs: HIVE-10705
https://issues.apache.org/jira/browse/HIVE-10705
Repository: hive-git
Description
-------
Summary:
1. remove binaries and make jar file in the runtime
2. move some common utilities to the HiveTestUtils
Diffs
-----
beeline/pom.xml 352f561
beeline/src/test/org/apache/hive/beeline/DummyDriver.java PRE-CREATION
beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java 7a354f3
beeline/src/test/resources/DummyDriver-1.0-SNAPSHOT.jar 3dadc9e
beeline/src/test/resources/DummyDriver.txt PRE-CREATION
beeline/src/test/resources/postgresql-9.3.jdbc3.jar f537b98
common/src/java/org/apache/hive/common/util/HiveTestUtils.java db34494
ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 45ad22a
Diff: https://reviews.apache.org/r/34922/diff/
Testing
-------
UT passed locally
Thanks,
cheng xu
Re: Review Request 34922: HIVE-10705 Update tests for HIVE-9302 after
removing binaries
Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34922/
-----------------------------------------------------------
(Updated June 3, 2015, 10:56 a.m.)
Review request for hive, Hari Sankar Sivarama Subramaniyan, Sushanth Sowmyan, and Vaibhav Gumashta.
Bugs: HIVE-10705
https://issues.apache.org/jira/browse/HIVE-10705
Repository: hive-git
Description
-------
Summary:
1. remove binaries and make jar file in the runtime
2. move some common utilities to the HiveTestUtils
Diffs (updated)
-----
beeline/pom.xml 352f561
beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java 7a354f3
beeline/src/test/resources/DummyDriver-1.0-SNAPSHOT.jar 3dadc9e
beeline/src/test/resources/DummyDriver.txt PRE-CREATION
beeline/src/test/resources/postgresql-9.3.jdbc3.jar f537b98
common/src/java/org/apache/hive/common/util/HiveTestUtils.java db34494
ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 45ad22a
Diff: https://reviews.apache.org/r/34922/diff/
Testing
-------
UT passed locally
Thanks,
cheng xu
Re: Review Request 34922: HIVE-10705 Update tests for HIVE-9302 after
removing binaries
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34922/#review86353
-----------------------------------------------------------
Ship it!
Ship It!
- Hari Sankar Sivarama Subramaniyan
On June 3, 2015, 2:52 a.m., cheng xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34922/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 2:52 a.m.)
>
>
> Review request for hive, Hari Sankar Sivarama Subramaniyan, Sushanth Sowmyan, and Vaibhav Gumashta.
>
>
> Bugs: HIVE-10705
> https://issues.apache.org/jira/browse/HIVE-10705
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Summary:
> 1. remove binaries and make jar file in the runtime
> 2. move some common utilities to the HiveTestUtils
>
>
> Diffs
> -----
>
> beeline/pom.xml 352f561
> beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java 7a354f3
> beeline/src/test/resources/DummyDriver.txt PRE-CREATION
> common/src/java/org/apache/hive/common/util/HiveTestUtils.java db34494
> ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 45ad22a
>
> Diff: https://reviews.apache.org/r/34922/diff/
>
>
> Testing
> -------
>
> UT passed locally
>
>
> Thanks,
>
> cheng xu
>
>
Re: Review Request 34922: HIVE-10705 Update tests for HIVE-9302 after
removing binaries
Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34922/
-----------------------------------------------------------
(Updated June 3, 2015, 10:52 a.m.)
Review request for hive, Hari Sankar Sivarama Subramaniyan, Sushanth Sowmyan, and Vaibhav Gumashta.
Bugs: HIVE-10705
https://issues.apache.org/jira/browse/HIVE-10705
Repository: hive-git
Description
-------
Summary:
1. remove binaries and make jar file in the runtime
2. move some common utilities to the HiveTestUtils
Diffs (updated)
-----
beeline/pom.xml 352f561
beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java 7a354f3
beeline/src/test/resources/DummyDriver.txt PRE-CREATION
common/src/java/org/apache/hive/common/util/HiveTestUtils.java db34494
ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 45ad22a
Diff: https://reviews.apache.org/r/34922/diff/
Testing
-------
UT passed locally
Thanks,
cheng xu
Re: Review Request 34922: HIVE-10705 Update tests for HIVE-9302 after
removing binaries
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34922/#review86275
-----------------------------------------------------------
beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java
<https://reviews.apache.org/r/34922/#comment138234>
Can the / in the path, for e.g. in /postgresql/postgresql/9.1-901.jdbc4/postgresql-9.1-901.jdbc4.jar be replaced with File.pathSeparator. For windows, we will have \ as the path separator and this can potentially cause an issue.
- Hari Sankar Sivarama Subramaniyan
On June 2, 2015, 5:15 a.m., cheng xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34922/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 5:15 a.m.)
>
>
> Review request for hive, Hari Sankar Sivarama Subramaniyan, Sushanth Sowmyan, and Vaibhav Gumashta.
>
>
> Bugs: HIVE-10705
> https://issues.apache.org/jira/browse/HIVE-10705
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Summary:
> 1. remove binaries and make jar file in the runtime
> 2. move some common utilities to the HiveTestUtils
>
>
> Diffs
> -----
>
> beeline/pom.xml 352f561
> beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java 7a354f3
> beeline/src/test/resources/DummyDriver-1.0-SNAPSHOT.jar 3dadc9e
> beeline/src/test/resources/DummyDriver.txt PRE-CREATION
> beeline/src/test/resources/postgresql-9.3.jdbc3.jar f537b98
> common/src/java/org/apache/hive/common/util/HiveTestUtils.java db34494
> ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 45ad22a
>
> Diff: https://reviews.apache.org/r/34922/diff/
>
>
> Testing
> -------
>
> UT passed locally
>
>
> Thanks,
>
> cheng xu
>
>
Re: Review Request 34922: HIVE-10705 Update tests for HIVE-9302 after
removing binaries
Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34922/
-----------------------------------------------------------
(Updated June 2, 2015, 1:15 p.m.)
Review request for hive, Hari Sankar Sivarama Subramaniyan, Sushanth Sowmyan, and Vaibhav Gumashta.
Bugs: HIVE-10705
https://issues.apache.org/jira/browse/HIVE-10705
Repository: hive-git
Description
-------
Summary:
1. remove binaries and make jar file in the runtime
2. move some common utilities to the HiveTestUtils
Diffs (updated)
-----
beeline/pom.xml 352f561
beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java 7a354f3
beeline/src/test/resources/DummyDriver-1.0-SNAPSHOT.jar 3dadc9e
beeline/src/test/resources/DummyDriver.txt PRE-CREATION
beeline/src/test/resources/postgresql-9.3.jdbc3.jar f537b98
common/src/java/org/apache/hive/common/util/HiveTestUtils.java db34494
ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 45ad22a
Diff: https://reviews.apache.org/r/34922/diff/
Testing
-------
UT passed locally
Thanks,
cheng xu