[GitHub] [iceberg] sshkvar commented on a change in pull request #2854: Spark catalog: fixed hardcoded purge option in drop table action

[GitBox <gi...@apache.org>]

sshkvar commented on a change in pull request #2854:
URL: https://github.com/apache/iceberg/pull/2854#discussion_r676423984



##########
File path: spark3/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -81,13 +81,17 @@
 public class SparkCatalog extends BaseCatalog {
   private static final Set<String> DEFAULT_NS_KEYS = ImmutableSet.of(TableCatalog.PROP_OWNER);
 
+  public static final String PURGE_DATA_AND_METADATA = "purge-data-and-metadata";

Review comment:
       Actually will use value of this property in Hive and Hadoop catalog, please take a look [on this method in Hive catalo, which will be called from spark catalog](https://github.com/apache/iceberg/blob/7779953bd2dad7990725391f9d5d8be077a7048d/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L148)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org