You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2020/07/26 16:50:13 UTC
svn commit: r1880332 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSNumber.java
Author: lehmi
Date: Sun Jul 26 16:50:12 2020
New Revision: 1880332
URL: http://svn.apache.org/viewvc?rev=1880332&view=rev
Log:
PDFBOX-4892: simplify code
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSNumber.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSNumber.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSNumber.java?rev=1880332&r1=1880331&r2=1880332&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSNumber.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSNumber.java Sun Jul 26 16:50:12 2020
@@ -74,27 +74,24 @@ public abstract class COSNumber extends
throw new IOException("Not a number: " + number);
}
}
- else if (isFloat(number))
+ if (isFloat(number))
{
return new COSFloat(number);
}
- else
+ try
{
- try
- {
- return COSInteger.get(Long.parseLong(number));
- }
- catch( NumberFormatException e )
+ return COSInteger.get(Long.parseLong(number));
+ }
+ catch (NumberFormatException e)
+ {
+ // check if the given string could be a number at all
+ String numberString = number.startsWith("+") || number.startsWith("-")
+ ? number.substring(1) : number;
+ if (!numberString.matches("[0-9]*"))
{
- // check if the given string could be a number at all
- String numberString = number.startsWith("+") || number.startsWith("-")
- ? number.substring(1) : number;
- if (!numberString.matches("[0-9]*"))
- {
- throw new IOException("Not a number: " + number);
- }
- return null;
+ throw new IOException("Not a number: " + number);
}
+ return null;
}
}