You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "justinmclean (via GitHub)" <gi...@apache.org> on 2024/04/03 06:13:28 UTC
[PR] Make it clearer that releases are non Apache releases [incubator-amoro-site]
justinmclean opened a new pull request, #8:
URL: https://github.com/apache/incubator-amoro-site/pull/8
Make it more apparent that releases are non-Apache releases and improve English.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make it clearer that releases are non Apache releases [incubator-amoro-site]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on code in PR #8:
URL: https://github.com/apache/incubator-amoro-site/pull/8#discussion_r1549031147
##########
amoro-site/content/download.md:
##########
@@ -6,17 +6,20 @@ disableSidebar: true
# Download
-Please choose an Amoro version to download from the blowing tables, the latest release is recommended.
-
+Please choose an Amoro version to download from the following tables. It is recommended you use the latest release.
## The latest release
+Coming soon!
+
+## Non-Apache releases
+
+These releases were made before the Amoro project joined the ASF Incubator and have not followed the usual ASF release process.
+
| Version | Date | Source | AMS | Flink Runtime Jars | Spark Runtime Jars | Trino Connector | Release Notes |
| --- | --- | --- | --- | --- | --- | --- | --- |
| 0.6.1 (non-Apache) | 2024 Feb 21 | [source](https://github.com/apache/incubator-amoro/archive/refs/tags/v0.6.1.zip) | - [AMS(hadoop3)](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-0.6.1-bin.zip) <br> - [AMS(hadoop2)](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-0.6.1-bin.hadoop2.zip) | - [Flink 1.15 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-flink-runtime-1.15-0.6.1.jar) <br> - [Flink 1.16 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-flink-runtime-1.16-0.6.1.jar) <br> - [Flink 1.17 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-flink-runtime-1.17-0.6.1.jar) <br> | - [Spark 3.1 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-spark-3.1-runtime-0.6.1.jar)<br> - [Spark 3.2 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-spark-3.2-runt
ime-0.6.1.jar)<br> - [Spark 3.3 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-spark-3.3-runtime-0.6.1.jar) | [Trino Connector](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/trino-amoro-0.6.1.tar.gz) | [release note](https://github.com/apache/incubator-amoro/releases/tag/v0.6.1) |
Review Comment:
No, we cannot, as it is not an ASF release. For it to be an ASF release, it needs to go through the ASF release process and be voted on by the Amoro PPMc and the Incubator PMC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make it clearer that releases are non Apache releases [incubator-amoro-site]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on code in PR #8:
URL: https://github.com/apache/incubator-amoro-site/pull/8#discussion_r1549049241
##########
amoro-site/content/download.md:
##########
@@ -6,17 +6,20 @@ disableSidebar: true
# Download
-Please choose an Amoro version to download from the blowing tables, the latest release is recommended.
-
+Please choose an Amoro version to download from the following tables. It is recommended you use the latest release.
## The latest release
+Coming soon!
+
+## Non-Apache releases
+
+These releases were made before the Amoro project joined the ASF Incubator and have not followed the usual ASF release process.
+
| Version | Date | Source | AMS | Flink Runtime Jars | Spark Runtime Jars | Trino Connector | Release Notes |
| --- | --- | --- | --- | --- | --- | --- | --- |
| 0.6.1 (non-Apache) | 2024 Feb 21 | [source](https://github.com/apache/incubator-amoro/archive/refs/tags/v0.6.1.zip) | - [AMS(hadoop3)](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-0.6.1-bin.zip) <br> - [AMS(hadoop2)](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-0.6.1-bin.hadoop2.zip) | - [Flink 1.15 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-flink-runtime-1.15-0.6.1.jar) <br> - [Flink 1.16 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-flink-runtime-1.16-0.6.1.jar) <br> - [Flink 1.17 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-flink-runtime-1.17-0.6.1.jar) <br> | - [Spark 3.1 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-spark-3.1-runtime-0.6.1.jar)<br> - [Spark 3.2 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-spark-3.2-runt
ime-0.6.1.jar)<br> - [Spark 3.3 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-spark-3.3-runtime-0.6.1.jar) | [Trino Connector](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/trino-amoro-0.6.1.tar.gz) | [release note](https://github.com/apache/incubator-amoro/releases/tag/v0.6.1) |
Review Comment:
I agree that version 0.6.1 is also a non-apache release and it is under the title: Non-Apache releases.
What I want to say is that in the release table, in order to maintain consistency with other versions' formats, we only fill in the version names in the "version" column and remove any additional descriptions.
However, we can improve the format in another PR, this PR is totally okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make it clearer that releases are non Apache releases [incubator-amoro-site]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on code in PR #8:
URL: https://github.com/apache/incubator-amoro-site/pull/8#discussion_r1549031147
##########
amoro-site/content/download.md:
##########
@@ -6,17 +6,20 @@ disableSidebar: true
# Download
-Please choose an Amoro version to download from the blowing tables, the latest release is recommended.
-
+Please choose an Amoro version to download from the following tables. It is recommended you use the latest release.
## The latest release
+Coming soon!
+
+## Non-Apache releases
+
+These releases were made before the Amoro project joined the ASF Incubator and have not followed the usual ASF release process.
+
| Version | Date | Source | AMS | Flink Runtime Jars | Spark Runtime Jars | Trino Connector | Release Notes |
| --- | --- | --- | --- | --- | --- | --- | --- |
| 0.6.1 (non-Apache) | 2024 Feb 21 | [source](https://github.com/apache/incubator-amoro/archive/refs/tags/v0.6.1.zip) | - [AMS(hadoop3)](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-0.6.1-bin.zip) <br> - [AMS(hadoop2)](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-0.6.1-bin.hadoop2.zip) | - [Flink 1.15 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-flink-runtime-1.15-0.6.1.jar) <br> - [Flink 1.16 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-flink-runtime-1.16-0.6.1.jar) <br> - [Flink 1.17 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-flink-runtime-1.17-0.6.1.jar) <br> | - [Spark 3.1 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-spark-3.1-runtime-0.6.1.jar)<br> - [Spark 3.2 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-spark-3.2-runt
ime-0.6.1.jar)<br> - [Spark 3.3 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-spark-3.3-runtime-0.6.1.jar) | [Trino Connector](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/trino-amoro-0.6.1.tar.gz) | [release note](https://github.com/apache/incubator-amoro/releases/tag/v0.6.1) |
Review Comment:
No, we cannot, as it is not an ASF release. For it to be an ASF release, it needs to go through the ASF release process and be voted on by the Amoro PPMC and the Incubator PMC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make it clearer that releases are non Apache releases [incubator-amoro-site]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on code in PR #8:
URL: https://github.com/apache/incubator-amoro-site/pull/8#discussion_r1548974339
##########
amoro-site/content/download.md:
##########
@@ -6,17 +6,20 @@ disableSidebar: true
# Download
-Please choose an Amoro version to download from the blowing tables, the latest release is recommended.
-
+Please choose an Amoro version to download from the following tables. It is recommended you use the latest release.
## The latest release
+Coming soon!
+
+## Non-Apache releases
+
+These releases were made before the Amoro project joined the ASF Incubator and have not followed the usual ASF release process.
+
| Version | Date | Source | AMS | Flink Runtime Jars | Spark Runtime Jars | Trino Connector | Release Notes |
| --- | --- | --- | --- | --- | --- | --- | --- |
| 0.6.1 (non-Apache) | 2024 Feb 21 | [source](https://github.com/apache/incubator-amoro/archive/refs/tags/v0.6.1.zip) | - [AMS(hadoop3)](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-0.6.1-bin.zip) <br> - [AMS(hadoop2)](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-0.6.1-bin.hadoop2.zip) | - [Flink 1.15 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-flink-runtime-1.15-0.6.1.jar) <br> - [Flink 1.16 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-flink-runtime-1.16-0.6.1.jar) <br> - [Flink 1.17 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-flink-runtime-1.17-0.6.1.jar) <br> | - [Spark 3.1 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-spark-3.1-runtime-0.6.1.jar)<br> - [Spark 3.2 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-spark-3.2-runt
ime-0.6.1.jar)<br> - [Spark 3.3 Runtime Jar](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/amoro-spark-3.3-runtime-0.6.1.jar) | [Trino Connector](https://github.com/apache/incubator-amoro/releases/download/v0.6.1/trino-amoro-0.6.1.tar.gz) | [release note](https://github.com/apache/incubator-amoro/releases/tag/v0.6.1) |
Review Comment:
Maybe we can drop the `(non-Apache)` description here for 0.6.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make it clearer that releases are non Apache releases [incubator-amoro-site]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #8:
URL: https://github.com/apache/incubator-amoro-site/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org