You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@seata.apache.org by "slievrly (via GitHub)" <gi...@apache.org> on 2026/10/02 15:39:37 UTC

Re: [PR] bugfix: stop Raft metadata submissions before node shutdown [incubator-seata]

slievrly commented on code in PR #8257:
URL: https://github.com/apache/incubator-seata/pull/8257#discussion_r4167295555


##########
server/src/main/java/org/apache/seata/server/cluster/raft/RaftStateMachine.java:
##########
@@ -231,7 +241,10 @@ public boolean onSnapshotLoad(final SnapshotReader reader) {
     }
 
     @Override
-    public void onLeaderStart(final long term) {
+    public synchronized void onLeaderStart(final long term) {

Review Comment:
   Confirmed the lock-order inversion. Commit 9a69ca01f uses the existing reentrant lock consistently for leader startup, metadata synchronization and prepareShutdown. The new coordinated two-thread regression times out on the original implementation and passes after the fix; both RaftShutdownCallbackTest cases pass in both configured Surefire executions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org