You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/25 03:59:48 UTC

[GitHub] cloud-fan commented on a change in pull request #23376: [SPARK-26435][SQL] Support creating partitioned table using Hive CTAS by specifying partition column names

cloud-fan commented on a change in pull request #23376: [SPARK-26435][SQL] Support creating partitioned table using Hive CTAS by specifying partition column names
URL: https://github.com/apache/spark/pull/23376#discussion_r243872335
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
 ##########
 @@ -1196,13 +1196,16 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder(conf) {
 
     selectQuery match {
       case Some(q) =>
-        // Hive does not allow to use a CTAS statement to create a partitioned table.
+        // Hive does not allow to use a CTAS statement to create a partitioned table
+        // by specifying table schema.
         if (tableDesc.partitionColumnNames.nonEmpty) {
           val errorMessage = "A Create Table As Select (CTAS) statement is not allowed to " +
-            "create a partitioned table using Hive's file formats. " +
+            "create a partitioned table using Hive's file formats by specifying table schema. " +
 
 Review comment:
   What does Hive report for this case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org