You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/08 11:14:11 UTC

[jira] [Commented] (FLINK-4173) Replace maven-assembly-plugin by maven-shade-plugin in flink-metrics

    [ https://issues.apache.org/jira/browse/FLINK-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367543#comment-15367543 ] 

ASF GitHub Bot commented on FLINK-4173:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/2216

    [FLINK-4173] Use shade-plugin in flink-metrics

    - replaced assembly-plugin with shade-plugin in graphite/ganglia
    - added shade-plugin to statsD
    - removed assembly-plugin in dropwizard

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 4173_metrics_shade

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2216
    
----
commit ab89373ec08e003378ff3979018c52b68f1cf4d7
Author: zentol <ch...@apache.org>
Date:   2016-07-08T10:15:51Z

    [FLINK-4173] Use shade-plugin in flink-metrics

----


> Replace maven-assembly-plugin by maven-shade-plugin in flink-metrics
> --------------------------------------------------------------------
>
>                 Key: FLINK-4173
>                 URL: https://issues.apache.org/jira/browse/FLINK-4173
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Chesnay Schepler
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> The modules {{flink-metrics-dropwizard}}, {{flink-metrics-ganglia}} and {{flink-metrics-graphite}} use the {{maven-assembly-plugin}} to build a fat jar. The resulting fat jar has the suffix {{jar-with-dependencies}}. In order to make the naming consistent with the rest of the system we should create a fat-jar without this suffix.
> Additionally we could replace the {{maven-assembly-plugin}} with the {{maven-shade-plugin}} to make it consistent with the rest of the system.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)