You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/17 15:20:11 UTC
[GitHub] [camel-website] aashnajena opened a new pull request #229: Fix side
nav-bar issues
aashnajena opened a new pull request #229: Fix side nav-bar issues
URL: https://github.com/apache/camel-website/pull/229
In the current website, the left-side nav-bar has the following issues :
- on hover, some of the links don't get underlined : this is because the CSS comes from a:hover so only external links show the change on hover. I have changed this so that all menu items turn orange and get underlined on hovering.
- In the User Manual, the submenu list under Architecture and Integration patterns is so long that if you open the drop-down, the menu becomes very long and difficult to navigate (you can't see the other main-menu items due to the long sub-menu list). I have changed this such that if the submenu takes > 200px height, it becomes scrollable instead of taking up the entire space of the main-menu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #229: Fix side
nav-bar issues
Posted by GitBox <gi...@apache.org>.
aashnajena edited a comment on issue #229: Fix side nav-bar issues
URL: https://github.com/apache/camel-website/pull/229#issuecomment-604578512
I thought about your comment and you're right, the design is too busy. Does removing the bold effect and the delimiting lines make the design less busy for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #229: Fix side
nav-bar issues
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #229: Fix side nav-bar issues
URL: https://github.com/apache/camel-website/pull/229#issuecomment-603166813
I'm sorry, I didn't understand the part about hover and menu reflow. If the user clicks on the drop-down arrow, the submenu opens up (and if sub-menu is too long, it becomes scrollable). If the grey background or the lines seem very distractive for you, I can remove that. Is that the concern?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #229: Fix side
nav-bar issues
Posted by GitBox <gi...@apache.org>.
aashnajena edited a comment on issue #229: Fix side nav-bar issues
URL: https://github.com/apache/camel-website/pull/229#issuecomment-604578512
I thought about your comment and you're right, the design is too busy. Does removing the bold effect and the delimiting lines make the design less busy for you?
Would you prefer this? Or should I stick to the original design and just try to fix the issue for (1) some items on the menu not showing hover effect and (2) adding scroll for extremely long submenus
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #229: Fix side
nav-bar issues
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #229: Fix side nav-bar issues
URL: https://github.com/apache/camel-website/pull/229#issuecomment-605013984
I understand the decisions behind those features now, thank you very much for explaining it to me. I think it's best if I close this PR and work on other issues!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #229: Fix side nav-bar
issues
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #229: Fix side nav-bar issues
URL: https://github.com/apache/camel-website/pull/229#issuecomment-604335256
@aashnajena this is what I see on the [preview](https://builds.apache.org/job/Camel.website/job/PR-229/Preview/manual/latest/):
See how the bold text forces the reflow on hover making the text jump below it.
To me this seems way to busy and I personally prefer the simpler version we currently have.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #229: Fix side
nav-bar issues
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #229: Fix side nav-bar issues
URL: https://github.com/apache/camel-website/pull/229#issuecomment-604578512
I thought about your comment and you're right, the design is too busy. Does removing the bold effect and the delimiting lines make the design less busy for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena closed pull request #229: Fix side
nav-bar issues
Posted by GitBox <gi...@apache.org>.
aashnajena closed pull request #229: Fix side nav-bar issues
URL: https://github.com/apache/camel-website/pull/229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #229: Fix side nav-bar
issues
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #229: Fix side nav-bar issues
URL: https://github.com/apache/camel-website/pull/229#issuecomment-604957155
I don't think there's an issue with making the currently selected topic bold. This is set on load of the page and will not cause reflows when user interacts with the webpage.
I think the idea of putting the expand/contract triangle on the right is a bit troublesome, it's close to the scrollbars (by default on the right side).
There's also an issue with additional scrollbar appearing when expanding certain sections like here:
This is also poor experience for the user as the user now has to use two scrollbars, think about the issues with the mouse scroll wheel.
So going back to the problem statement:
- _on hover, some of the links don't get underlined_ - the elements that don't get underline effect are not in fact links, they only serve to expand contract sections for example in the "User manual" the "Domain Specific Languages" is not a link if you click on it it only expands topics within it so I don't see a problem with that
- _the submenu list under Architecture and Integration patterns is so long that if you open the drop-down_ - either way scrollbar appears, having smaller area to scroll is worse in my opinion (see above)
- _drop-down arrow buttons on the left seem uneven, since they are not present for every item and hence the menu looks oddly indented_ - not seeing the unevenness, they would be present only for topics that have topics nested within them, alignment looks correct to me, perhaps you can provide a screenshot of an example where this is a problem
We have a [separate issue](https://issues.apache.org/jira/browse/CAMEL-14797) for the discrepancy in the component quick search, please reach out to @psingh587 so there's no duplicate work for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #229: Fix side
nav-bar issues
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #229: Fix side nav-bar issues
URL: https://github.com/apache/camel-website/pull/229#issuecomment-604339437
Ahh I see, I agree, this is not good. So should I undo this bold effect (so that menu does not reflow)? Or would you prefer if I close this pull request completely...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #229: Fix side
nav-bar issues
Posted by GitBox <gi...@apache.org>.
aashnajena edited a comment on issue #229: Fix side nav-bar issues
URL: https://github.com/apache/camel-website/pull/229#issuecomment-604339437
Ahh I see, I agree, this is not good. So should I undo this bold effect (so that menu does not reflow)? Or would you prefer if I close this pull request completely...
On another note, the same bold effect happens when you click on a menu item on the current website. Maybe we should look into that as well...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services