You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/08/01 07:52:53 UTC

[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #520: Remove javafmtOnCompile and check in CI

mdedetrich opened a new pull request, #520:
URL: https://github.com/apache/incubator-pekko/pull/520

   Currently Pekko formats java code on compile which has the unforunate consequence of formatting the entire codebase even when just running due to us generating Scala source code on compile, i.e.
   
   ```
   pekko > cluster/MultiJvm/test
   [info] Formatting 1 Java source...
   [info] Reformatted 0 Java sources
   [info] 3 file(s) merged using strategy 'Rename' (Run the task at debug level to see the details)
   [info] 2 file(s) merged using strategy 'Discard' (Run the task at debug level to see the details)
   [info] Built: /home/mdedetrich/github/incubator-pekko/protobuf-v3/target/scala-2.13/pekko-protobuf-v3-assembly-1.0.0+26-ad512ebf-SNAPSHOT.jar
   [info] Jar hash: e4c3375316507c107622553eab40d960cae9e132
   [info] Formatting 3 Java sources...
   [info] Reformatted 0 Java sources
   [info] Formatting 2 Java sources...
   [info] Reformatted 0 Java sources
   [info] Formatting 23 Java sources...
   [info] Reformatted 0 Java sources
   [info] Formatting 3 Java sources...
   [info] Reformatted 0 Java sources
   [info] Formatting 4 Java sources...
   [info] Reformatted 0 Java sources
   [info] Formatting 27 Java sources...
   [info] Reformatted 0 Java sources
   [info] Formatting 1 Java source...
   [info] Reformatted 0 Java sources
   [info] Formatting 20 Java sources...
   [info] Reformatted 0 Java sources
   [info] Generating 'FanInShapeN.scala'
   [info] Generating 'FanOutShapeN.scala'
   [info] Generating 'GraphApply.scala'
   [info] Generating 'UnzipWithApply.scala'
   [info] Generating 'ZipLatestWithApply.scala'
   [info] Generating 'ZipWithApply.scala'
   [info] Generating 'ZipLatestWith.scala'
   [info] Generating 'UnzipWith.scala'
   [info] Generating 'GraphCreate.scala'
   [info] Generating 'ZipWith.scala'
   [info] Generating 'Tuples.scala'
   [info] Generating 'Functions.scala'
   ```
   
   Also in general Pekko projects have moved away from formatting code on compile since we are checking that code is formatted in CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] mdedetrich merged pull request #520: Remove javafmtOnCompile and check in CI

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #520:
URL: https://github.com/apache/incubator-pekko/pull/520


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org