[jira] [Commented] (MPIR-435) Custom bundle sometimes not loaded due to parent-first class loading

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MPIR-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720688#comment-17720688 ] 

ASF GitHub Bot commented on MPIR-435:
-------------------------------------

michael-o opened a new pull request, #48:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/48

   …ss loading
   
   This closes #48
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPIR) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MPIR-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MPIR-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Custom bundle sometimes not loaded due to parent-first class loading
> --------------------------------------------------------------------
>
>                 Key: MPIR-435
>                 URL: https://issues.apache.org/jira/browse/MPIR-435
>             Project: Maven Project Info Reports Plugin
>          Issue Type: Bug
>    Affects Versions: 3.4.3
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 3.4.4
>
>
> When a custom bundle is provided and the name is identical the the bundled one and if the class loader uses a parent-first (default) approach then the custom bundle isn't considered at all because the parent CL contains it already. The {{URLClassLoader}} we pass must not have a parent in this case.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)