You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/17 13:12:00 UTC

[jira] [Commented] (FLINK-7212) JobManagerLeaderSessionIDITSuite not executed

    [ https://issues.apache.org/jira/browse/FLINK-7212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089803#comment-16089803 ] 

ASF GitHub Bot commented on FLINK-7212:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4354

    [FLINK-7212][tests] re-enable JobManagerLeaderSessionIDITCase

    This test was previously named JobManagerLeaderSessionIDITSuite and has not
    been executed for a while by maven because of it having the wrong naming
    scheme. After a renaming, it runs again but needed a minor change to be
    successful again which is included in this commit.
    
    - [X] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [X] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7212

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4354
    
----
commit 52fa0198226da90d97b49b9d73eb92e34c26dbd9
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-07-17T12:46:17Z

    [FLINK-7212][tests] re-enable JobManagerLeaderSessionIDITCase
    
    This test was previously named JobManagerLeaderSessionIDITSuite and has not
    been executed for a while by maven because of it having the wrong naming
    scheme. After a renaming, it runs again but needed a minor change to be
    successful again which is included in this commit.

----


> JobManagerLeaderSessionIDITSuite not executed
> ---------------------------------------------
>
>                 Key: FLINK-7212
>                 URL: https://issues.apache.org/jira/browse/FLINK-7212
>             Project: Flink
>          Issue Type: Bug
>          Components: JobManager, Tests
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> {{JobManagerLeaderSessionIDITSuite}} is currently not executed due to its naming scheme. Only {{*ITCase}} and {{*Test}} classes are run, except for inside {{flink-ml}} which adds more patters to the {{scalatest}} plugin.
> Also, {{JobManagerLeaderSessionIDITSuite}} needs to be adapted slightly so that it runs successfully.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)