You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by afs <gi...@git.apache.org> on 2017/06/21 18:17:59 UTC

[GitHub] jena pull request #265: JENA-1366: Fuseki embedded as a standalone server

GitHub user afs opened a pull request:

    https://github.com/apache/jena/pull/265

    JENA-1366: Fuseki embedded as a standalone server

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afs/jena fuseki-basic

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #265
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena issue #265: JENA-1366: Fuseki embedded as a standalone server

Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:

    https://github.com/apache/jena/pull/265
  
    Planning to test it this weekend, but in case I take too long, the pull request is only adding code, that seems good to me. I want to give it a try so that I learn what it is doing, and can also perhaps help with the documentation later :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena issue #265: JENA-1366: Fuseki embedded as a standalone server

Posted by afs <gi...@git.apache.org>.
Github user afs commented on the issue:

    https://github.com/apache/jena/pull/265
  
    `shellcheck` needs to try harder :-) 
    
    I'll fix `$FUSEKI_JAR`. The others are supposed to expand to zero, one or more exec arguments.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena issue #265: JENA-1366: Fuseki embedded as a standalone server

Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:

    https://github.com/apache/jena/pull/265
  
    Double checked the messages displayed to user, all look goods, no typos or confusing text. Very simple to understand how to use it. The provided shell scripts are helpful too, as well as comments in Java and shell in case users want to customize it.
    
    `shellcheck` complains only about some strings not quoted in the run-sparqler script.
    
    ```
    kinow@localhost:~/Development/java/jena/jena/jena-fuseki2/jena-fuseki-basic/sparqler$ shellcheck run-sparqler 
    
    In run-sparqler line 55:
        exec java $JVM_ARGS $FUSEKI_LOG -jar $FUSEKI_JAR $SPARQLER_ARGS
                  ^-- SC2086: Double quote to prevent globbing and word splitting.
                            ^-- SC2086: Double quote to prevent globbing and word splitting.
                                             ^-- SC2086: Double quote to prevent globbing and word splitting.
                                                         ^-- SC2086: Double quote to prevent globbing and word splitting.
    
    
    In run-sparqler line 59:
        nohup java $JVM_ARGS $FUSEKI_LOG -jar $FUSEKI_JAR $SPARQLER_ARGS > nohup.log 2>&1 &
                   ^-- SC2086: Double quote to prevent globbing and word splitting.
                             ^-- SC2086: Double quote to prevent globbing and word splitting.
                                              ^-- SC2086: Double quote to prevent globbing and word splitting.
                                                          ^-- SC2086: Double quote to prevent globbing and word splitting.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena issue #265: JENA-1366: Fuseki embedded as a standalone server

Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:

    https://github.com/apache/jena/pull/265
  
    Everything working now :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena issue #265: JENA-1366: Fuseki embedded as a standalone server

Posted by afs <gi...@git.apache.org>.
Github user afs commented on the issue:

    https://github.com/apache/jena/pull/265
  
    Error `No source specified` fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena issue #265: JENA-1366: Fuseki embedded as a standalone server

Posted by afs <gi...@git.apache.org>.
Github user afs commented on the issue:

    https://github.com/apache/jena/pull/265
  
    Thanks!
    
    The module structure of Fuseki2 is now a bit messy, but tolerable. What the right structure is can wait; it needs to balance usefulness (not too many module) with detailed structure (each different aspect a module).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena pull request #265: JENA-1366: Fuseki embedded as a standalone server

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/jena/pull/265


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---