[GitHub] [arrow] kou commented on a diff in pull request #36016: GH-36013: [C++] Disabling bundled opentelemetry

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #36016:
URL: https://github.com/apache/arrow/pull/36016#discussion_r1224777213


##########
ci/docker/ubuntu-22.04-cpp.dockerfile:
##########
@@ -197,3 +196,7 @@ ENV absl_SOURCE=BUNDLED \
     PATH=/usr/lib/ccache/:$PATH \
     PYTHON=python3 \
     xsimd_SOURCE=BUNDLED
+
+# GH-36013 disabling opentelemetry here because we can't
+# get the patched version from conda
+#    ARROW_WITH_OPENTELEMETRY=ON \

Review Comment:
   We can use comment in `ENV`:
   
   ```diff
   diff --git a/ci/docker/ubuntu-22.04-cpp.dockerfile b/ci/docker/ubuntu-22.04-cpp.dockerfile
   index e6fd44ff2..6dc5ccbcb 100644
   --- a/ci/docker/ubuntu-22.04-cpp.dockerfile
   +++ b/ci/docker/ubuntu-22.04-cpp.dockerfile
   @@ -184,7 +184,9 @@ ENV absl_SOURCE=BUNDLED \
        ARROW_WITH_BROTLI=ON \
        ARROW_WITH_BZ2=ON \
        ARROW_WITH_LZ4=ON \
   -    ARROW_WITH_OPENTELEMETRY=ON \
   +    # GH-36013 disabling opentelemetry here because we can't
   +    # get the patched version from conda
   +    # ARROW_WITH_OPENTELEMETRY=ON \
        ARROW_WITH_SNAPPY=ON \
        ARROW_WITH_ZLIB=ON \
        ARROW_WITH_ZSTD=ON \
   ```



##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -109,6 +109,12 @@ if("${jemalloc_SOURCE}" STREQUAL "")
   set(jemalloc_SOURCE "BUNDLED")
 endif()
 
+# GH-36013 bundled opentelemetry-cpp build is broken, change the default
+# to CONDA until a patched bundled version is available.
+if("${opentelemetry-cpp_SOURCE}" STREQUAL "")
+  set(opentelemetry-cpp_SOURCE "CONDA")
+endif()
+

Review Comment:
   Do we need this?
   I think that this is needless. I think that we just need to disable OpenTelemetry without conda.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org