You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/03/02 15:12:40 UTC

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #865: Several fixes.

qiaojialin commented on a change in pull request #865: Several fixes.
URL: https://github.com/apache/incubator-iotdb/pull/865#discussion_r386451156
 
 

 ##########
 File path: grafana/src/main/java/org/apache/iotdb/web/grafana/dao/impl/BasicDaoImpl.java
 ##########
 @@ -104,9 +103,10 @@ public Object doInConnection(Connection connection) throws SQLException {
   public List<TimeValues> querySeries(String s, Pair<ZonedDateTime, ZonedDateTime> timeRange) {
     Long from = zonedCovertToLong(timeRange.left);
     Long to = zonedCovertToLong(timeRange.right);
-    String sql = "SELECT " + s.substring(s.lastIndexOf('.') + 1) + " FROM root."
-        + s.substring(0, s.lastIndexOf('.')) + " WHERE time > " + from * TIMESTAMP_RADIX
-        + " and time < " + to * TIMESTAMP_RADIX;
+    // How many rows will the result have?
 
 Review comment:
   do you want to get the precise result or a fuzy one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services