You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/10/25 17:03:12 UTC
[jira] [Created] (BOOKKEEPER-444) Refactor pending read op to make
speculative reads possible
Ivan Kelly created BOOKKEEPER-444:
-------------------------------------
Summary: Refactor pending read op to make speculative reads possible
Key: BOOKKEEPER-444
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-444
Project: Bookkeeper
Issue Type: Sub-task
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Fix For: 4.2.0
The code to handle the state of a single entry read request is scattered all over PendingReadOp. Some even leaks into LedgerEntry. This jira is to refactor this code into one place to make speculative reads easier to implement.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-444) Refactor pending read op to
make speculative reads possible
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492546#comment-13492546 ]
Hudson commented on BOOKKEEPER-444:
-----------------------------------
Integrated in bookkeeper-trunk #793 (See [https://builds.apache.org/job/bookkeeper-trunk/793/])
BOOKKEEPER-444: Refactor pending read op to make speculative reads possible (ivank) (Revision 1406707)
Result = UNSTABLE
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntry.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
> Refactor pending read op to make speculative reads possible
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-444
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-444
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-BOOKKEEPER-444-Refactor-pending-read-op-to-make-spec.patch, 0001-BOOKKEEPER-444-Refactor-pending-read-op-to-make-spec.patch
>
>
> The code to handle the state of a single entry read request is scattered all over PendingReadOp. Some even leaks into LedgerEntry. This jira is to refactor this code into one place to make speculative reads easier to implement.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-444) Refactor pending read op to make
speculative reads possible
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-444:
----------------------------------
Attachment: 0001-BOOKKEEPER-444-Refactor-pending-read-op-to-make-spec.patch
addressed comments in new patch. I have also replied on reviewboard.
> Refactor pending read op to make speculative reads possible
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-444
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-444
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-BOOKKEEPER-444-Refactor-pending-read-op-to-make-spec.patch, 0001-BOOKKEEPER-444-Refactor-pending-read-op-to-make-spec.patch
>
>
> The code to handle the state of a single entry read request is scattered all over PendingReadOp. Some even leaks into LedgerEntry. This jira is to refactor this code into one place to make speculative reads easier to implement.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-444) Refactor pending read op to
make speculative reads possible
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485672#comment-13485672 ]
Rakesh R commented on BOOKKEEPER-444:
-------------------------------------
Thanks Ivan for the patch and looks pretty nice. I've posted few suggestions in the review board.
> Refactor pending read op to make speculative reads possible
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-444
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-444
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-BOOKKEEPER-444-Refactor-pending-read-op-to-make-spec.patch
>
>
> The code to handle the state of a single entry read request is scattered all over PendingReadOp. Some even leaks into LedgerEntry. This jira is to refactor this code into one place to make speculative reads easier to implement.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-444) Refactor pending read op to make
speculative reads possible
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-444:
----------------------------------
Attachment: 0001-BOOKKEEPER-444-Refactor-pending-read-op-to-make-spec.patch
straight forward refactor
> Refactor pending read op to make speculative reads possible
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-444
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-444
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-BOOKKEEPER-444-Refactor-pending-read-op-to-make-spec.patch
>
>
> The code to handle the state of a single entry read request is scattered all over PendingReadOp. Some even leaks into LedgerEntry. This jira is to refactor this code into one place to make speculative reads easier to implement.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-444) Refactor pending read op to
make speculative reads possible
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484206#comment-13484206 ]
Ivan Kelly commented on BOOKKEEPER-444:
---------------------------------------
https://reviews.apache.org/r/7733/
> Refactor pending read op to make speculative reads possible
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-444
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-444
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-BOOKKEEPER-444-Refactor-pending-read-op-to-make-spec.patch
>
>
> The code to handle the state of a single entry read request is scattered all over PendingReadOp. Some even leaks into LedgerEntry. This jira is to refactor this code into one place to make speculative reads easier to implement.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira