You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Arjun Mishra via Review Board <no...@reviews.apache.org> on 2018/06/26 14:55:51 UTC
Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER task
for Hive
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67745/
-----------------------------------------------------------
Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
Repository: sentry
Description
-------
The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported DDL tasks for authorization in Hive. We need to add the support for the SHOW GRANT USER as well.
Diffs
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 660bef115
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java 8b6b223da
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java 500b38b0c
Diff: https://reviews.apache.org/r/67745/diff/1/
Testing
-------
Thanks,
Arjun Mishra
Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER
task for Hive
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67745/#review205450
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On June 27, 2018, 4:30 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67745/
> -----------------------------------------------------------
>
> (Updated June 27, 2018, 4:30 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported DDL tasks for authorization in Hive. We need to add the support for the SHOW GRANT USER as well.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java e58fe86a2
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java e497f8c78
>
>
> Diff: https://reviews.apache.org/r/67745/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER
task for Hive
Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
> On June 27, 2018, 7:18 p.m., Na Li wrote:
> > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java
> > Lines 391 (patched)
> > <https://reviews.apache.org/r/67745/diff/3/?file=2046402#file2046402line391>
> >
> > this is duplicate of line 393. should you remove it?
Good catch. There are several duplicates in other methods. Will fix them
- Arjun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67745/#review205466
-----------------------------------------------------------
On June 27, 2018, 5:34 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67745/
> -----------------------------------------------------------
>
> (Updated June 27, 2018, 5:34 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2273
> https://issues.apache.org/jira/browse/SENTRY-2273
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported DDL tasks for authorization in Hive. We need to add the support for the SHOW GRANT USER as well.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java e58fe86a2
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java e497f8c78
>
>
> Diff: https://reviews.apache.org/r/67745/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER
task for Hive
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67745/#review205466
-----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java
Lines 391 (patched)
<https://reviews.apache.org/r/67745/#comment288380>
this is duplicate of line 393. should you remove it?
- Na Li
On June 27, 2018, 5:34 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67745/
> -----------------------------------------------------------
>
> (Updated June 27, 2018, 5:34 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2273
> https://issues.apache.org/jira/browse/SENTRY-2273
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported DDL tasks for authorization in Hive. We need to add the support for the SHOW GRANT USER as well.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java e58fe86a2
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java e497f8c78
>
>
> Diff: https://reviews.apache.org/r/67745/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER
task for Hive
Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67745/#review205467
-----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java
Lines 391 (patched)
<https://reviews.apache.org/r/67745/#comment288381>
Good catch. There are several duplicates in other methods. Will fix them
- Arjun Mishra
On June 27, 2018, 5:34 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67745/
> -----------------------------------------------------------
>
> (Updated June 27, 2018, 5:34 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2273
> https://issues.apache.org/jira/browse/SENTRY-2273
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported DDL tasks for authorization in Hive. We need to add the support for the SHOW GRANT USER as well.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java e58fe86a2
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java e497f8c78
>
>
> Diff: https://reviews.apache.org/r/67745/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER
task for Hive
Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67745/
-----------------------------------------------------------
(Updated June 27, 2018, 5:34 p.m.)
Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
Bugs: SENTRY-2273
https://issues.apache.org/jira/browse/SENTRY-2273
Repository: sentry
Description
-------
The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported DDL tasks for authorization in Hive. We need to add the support for the SHOW GRANT USER as well.
Diffs
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java e58fe86a2
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java e497f8c78
Diff: https://reviews.apache.org/r/67745/diff/3/
Testing
-------
Thanks,
Arjun Mishra
Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER
task for Hive
Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67745/
-----------------------------------------------------------
(Updated June 27, 2018, 4:30 p.m.)
Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
Repository: sentry
Description
-------
The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported DDL tasks for authorization in Hive. We need to add the support for the SHOW GRANT USER as well.
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java e58fe86a2
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java e497f8c78
Diff: https://reviews.apache.org/r/67745/diff/3/
Changes: https://reviews.apache.org/r/67745/diff/2-3/
Testing
-------
Thanks,
Arjun Mishra
Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER
task for Hive
Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
> On June 26, 2018, 4:37 p.m., Na Li wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java
> > Lines 235 (patched)
> > <https://reviews.apache.org/r/67745/diff/2/?file=2045134#file2045134line235>
> >
> > why do you leave the code commented? The test should verify that command retrives the result
There should be another ticket that addresses this. Basically user privileges are not being created when a create database command is executed. Because of this the show grant user command will fail
- Arjun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67745/#review205379
-----------------------------------------------------------
On June 26, 2018, 4:25 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67745/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 4:25 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported DDL tasks for authorization in Hive. We need to add the support for the SHOW GRANT USER as well.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 660bef115
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java 8b6b223da
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java 500b38b0c
>
>
> Diff: https://reviews.apache.org/r/67745/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER
task for Hive
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67745/#review205379
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java
Lines 235 (patched)
<https://reviews.apache.org/r/67745/#comment288273>
why do you leave the code commented? The test should verify that command retrives the result
- Na Li
On June 26, 2018, 4:25 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67745/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 4:25 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported DDL tasks for authorization in Hive. We need to add the support for the SHOW GRANT USER as well.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 660bef115
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java 8b6b223da
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java 500b38b0c
>
>
> Diff: https://reviews.apache.org/r/67745/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER
task for Hive
Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67745/#review205380
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java
Lines 235 (patched)
<https://reviews.apache.org/r/67745/#comment288274>
There should be another ticket that addresses this. Basically user privileges are not being created when a create database command is executed. Because of this the show grant user command will fail
- Arjun Mishra
On June 26, 2018, 4:25 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67745/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 4:25 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported DDL tasks for authorization in Hive. We need to add the support for the SHOW GRANT USER as well.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 660bef115
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java 8b6b223da
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java 500b38b0c
>
>
> Diff: https://reviews.apache.org/r/67745/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER
task for Hive
Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67745/
-----------------------------------------------------------
(Updated June 26, 2018, 4:25 p.m.)
Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
Repository: sentry
Description
-------
The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported DDL tasks for authorization in Hive. We need to add the support for the SHOW GRANT USER as well.
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 660bef115
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java 8b6b223da
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java 500b38b0c
Diff: https://reviews.apache.org/r/67745/diff/2/
Changes: https://reviews.apache.org/r/67745/diff/1-2/
Testing
-------
Thanks,
Arjun Mishra
Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER
task for Hive
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67745/#review205372
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On June 26, 2018, 2:55 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67745/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 2:55 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported DDL tasks for authorization in Hive. We need to add the support for the SHOW GRANT USER as well.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 660bef115
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java 8b6b223da
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java 500b38b0c
>
>
> Diff: https://reviews.apache.org/r/67745/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>