[GitHub] [beam] pabloem commented on a change in pull request #15510: [BEAM-12883] Add coder for ReadableFileCoder that supports MetadataCoderV2

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #15510:
URL: https://github.com/apache/beam/pull/15510#discussion_r721764664



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/ReadableFileCoder.java
##########
@@ -20,31 +20,63 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
-import org.apache.beam.sdk.coders.AtomicCoder;
-import org.apache.beam.sdk.coders.Coder;
-import org.apache.beam.sdk.coders.VarIntCoder;
+import java.util.Collections;
+import java.util.List;
+import org.apache.beam.sdk.coders.*;

Review comment:
       this asterisk-based import is causing the PreCommit to fail (we try to avoid this sort of import) - can you import only the classes you need?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org