You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/25 20:47:37 UTC

[GitHub] [arrow-rs] viirya opened a new pull request, #3197: Add dictionary suppport to like, ilike, nlike, nilike kernels

viirya opened a new pull request, #3197:
URL: https://github.com/apache/arrow-rs/pull/3197

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #1975.
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #3197: Add _dyn kernels of like, ilike, nlike, nilike kernels for dictionary support

Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3197:
URL: https://github.com/apache/arrow-rs/pull/3197


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] viirya commented on pull request #3197: Add dictionary suppport to like, ilike, nlike, nilike kernels

Posted by GitBox <gi...@apache.org>.
viirya commented on PR #3197:
URL: https://github.com/apache/arrow-rs/pull/3197#issuecomment-1328098768

   > We don't seem to provide `eq_dict` or `gt_dict` instead this is hidden within `eq_dyn`, perhaps we should do the same here?
   
   I think it is because there are `like_dict_scalar`, `nlike_dict_scalar` etc for dictionary arrays. I agree that for other comparison kernels, only primitive and _dyn kernels are available. Maybe we should remove these `_dict_scalar` and only keep `_dyn` for dictionary support?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] psvri commented on pull request #3197: Add dictionary suppport to like, ilike, nlike, nilike kernels

Posted by GitBox <gi...@apache.org>.
psvri commented on PR #3197:
URL: https://github.com/apache/arrow-rs/pull/3197#issuecomment-1328076197

   Thanks @viirya for implementing the rest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #3197: Add dictionary suppport to like, ilike, nlike, nilike kernels

Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3197:
URL: https://github.com/apache/arrow-rs/pull/3197#issuecomment-1328099017

   That sounds good to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] ursabot commented on pull request #3197: Add _dyn kernels of like, ilike, nlike, nilike kernels for dictionary support

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3197:
URL: https://github.com/apache/arrow-rs/pull/3197#issuecomment-1328887339

   Benchmark runs are scheduled for baseline = f985818012e6d0a56fca49487dbc13c516f4613c and contender = a6daff5fcc360f9c570cc20cae26b53373af8d9b. a6daff5fcc360f9c570cc20cae26b53373af8d9b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ea5f3b2bc9db4d7185b4f95ba7250dea...85e855e20b87421e90151a48e8b137e7/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/af824616760945678ce66344419753bf...82028f1487834fb0b21d30df83a5ad4a/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8ec3010fc7114c7aa1c7dc0f2af0061f...f54352b51a7b4d358ec0431d2c9a522f/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/725a7156c63a44e6bbb8fff565c54e47...67a5488d8b8846dd81086950f9835c3b/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org