You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@linkis.apache.org by GitBox <gi...@apache.org> on 2022/04/17 12:38:57 UTC
[GitHub] [incubator-linkis] iture123 opened a new pull request, #1989: [fix #1761]command "ip addr" maybe return multiple ips
iture123 opened a new pull request, #1989:
URL: https://github.com/apache/incubator-linkis/pull/1989
### What is the purpose of the change
#1761
### Brief change log
command "ip addr" maybe return multiple ips,fix the situation.
### Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- Anything that affects deployment: no
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: no
### Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #1989: [fix #1761]command "ip addr" maybe return multiple ips
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #1989:
URL: https://github.com/apache/incubator-linkis/pull/1989#discussion_r854219679
##########
web/config.sh:
##########
@@ -21,4 +21,4 @@ linkis_port="8088"
linkis_url="http://localhost:20401"
#linkis ip address
-linkis_ipaddr=$(ip addr | awk '/^[0-9]+: / {}; /inet.*global/ {print gensub(/(.*)\/(.*)/, "\\1", "g", $2)}')
+linkis_ipaddr=localhost
Review Comment:
the service of linkis-mg-gateway default port is 9001
I think it should be consistent
```
#URL of the backend service of linkis-mg-gateway
linkis_url="http://127.0.0.1:9001"
#linkis ip address，the htpp access address for linkis-web will be http://${linkis_ipaddr}:${linkis_port}
linkis_ipaddr=127.0.0.1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on pull request #1989: [fix #1761]command "ip addr" maybe return multiple ips
Posted by GitBox <gi...@apache.org>.
casionone commented on PR #1989:
URL: https://github.com/apache/incubator-linkis/pull/1989#issuecomment-1104016639
The install scrptis `web/install.sh`
Some useless operations shell code should be removed
```
echo '安装visualis前端,用户自行编译linkis前端安装包，则安装时需要把visualis的前端安装包放置于此'$linkis_basepath/linkis/visualis'，用于自动化安装:'
cd $linkis_basepath/linkis/visualis;unzip -o build.zip > /dev/null
```
This code is useless and can easily cause confusion，Please help to delete it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone merged pull request #1989: [fix #1761]command "ip addr" maybe return multiple ips
Posted by GitBox <gi...@apache.org>.
casionone merged PR #1989:
URL: https://github.com/apache/incubator-linkis/pull/1989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] iture123 commented on pull request #1989: [fix #1761]command "ip addr" maybe return multiple ips
Posted by GitBox <gi...@apache.org>.
iture123 commented on PR #1989:
URL: https://github.com/apache/incubator-linkis/pull/1989#issuecomment-1107475268
> The install scrptis `web/install.sh` Some useless operations shell code should be removed
>
> ```
> echo '安装visualis前端,用户自行编译linkis前端安装包，则安装时需要把visualis的前端安装包放置于此'$linkis_basepath/linkis/visualis'，用于自动化安装:'
> cd $linkis_basepath/linkis/visualis;unzip -o build.zip > /dev/null
> ```
>
> This code is useless and can easily cause confusion，Please help to delete it
already deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] iture123 commented on a diff in pull request #1989: [fix #1761]command "ip addr" maybe return multiple ips
Posted by GitBox <gi...@apache.org>.
iture123 commented on code in PR #1989:
URL: https://github.com/apache/incubator-linkis/pull/1989#discussion_r857721225
##########
web/config.sh:
##########
@@ -21,4 +21,4 @@ linkis_port="8088"
linkis_url="http://localhost:20401"
#linkis ip address
-linkis_ipaddr=$(ip addr | awk '/^[0-9]+: / {}; /inet.*global/ {print gensub(/(.*)\/(.*)/, "\\1", "g", $2)}')
+linkis_ipaddr=localhost
Review Comment:
> the service of linkis-mg-gateway default port is 9001 I think it should be consistent
>
> ```
> #URL of the backend service of linkis-mg-gateway
> linkis_url="http://127.0.0.1:9001"
>
> #linkis ip address，the htpp access address for linkis-web will be http://${linkis_ipaddr}:${linkis_port}
> linkis_ipaddr=127.0.0.1
> ```
you are right,it`s fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #1989: [fix #1761]command "ip addr" maybe return multiple ips
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #1989:
URL: https://github.com/apache/incubator-linkis/pull/1989#discussion_r860805440
##########
web/config.sh:
##########
@@ -14,11 +14,13 @@
# limitations under the License.
#
-#Configuring front-end ports
-linkis_port="8088"
-#URL of the backend linkis gateway
-linkis_url="http://localhost:20401"
-#linkis ip address
-linkis_ipaddr=$(ip addr | awk '/^[0-9]+: / {}; /inet.*global/ {print gensub(/(.*)\/(.*)/, "\\1", "g", $2)}')
+#URL of the backend service of linkis-mg-gateway
+linkis_url="http://127.0.0.1:9001"
+
+#linkis ip address，the http access address for linkis-web will be http://${linkis_ipaddr}:${linkis_port}
+linkis_ipaddr=127.0.0.1
+linkis_port=8088
+
+web/install.sh
Review Comment:
exce web/install.sh action in config scripts?it seems unreasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #1989: [fix #1761]command "ip addr" maybe return multiple ips
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1989:
URL: https://github.com/apache/incubator-linkis/pull/1989#issuecomment-1107477630
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/1989?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`dev-1.1.2@9ffda4d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev-1.1.2 #1989 +/- ##
============================================
Coverage ? 18.34%
Complexity ? 703
============================================
Files ? 344
Lines ? 10720
Branches ? 1606
============================================
Hits ? 1967
Misses ? 8551
Partials ? 202
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/1989?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/1989?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9ffda4d...720b7bb](https://codecov.io/gh/apache/incubator-linkis/pull/1989?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org