You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2017/10/18 15:49:37 UTC
Review Request 63113: Fix flakyness in
'SlaveTest.ExecutorShutdownGracePeriod'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63113/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
On slow systems, it could happen that an additional offer was
delivered to the scheduler before the test case finished.
Diffs
-----
src/tests/slave_tests.cpp 91d97d195acd695ae9c469651596511eafb50557
Diff: https://reviews.apache.org/r/63113/diff/1/
Testing
-------
./mesos-tests --gtest_filter="*ExecutorShutdownGracePeriod*" --gtest_repeat=5000 --gtest_break_on_failure
Thanks,
Benno Evers
Re: Review Request 63113: Fix flakyness in
'SlaveTest.ExecutorShutdownGracePeriod'.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63113/#review188550
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Oct. 18, 2017, 3:49 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63113/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 3:49 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On slow systems, it could happen that an additional offer was
> delivered to the scheduler before the test case finished.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 91d97d195acd695ae9c469651596511eafb50557
>
>
> Diff: https://reviews.apache.org/r/63113/diff/1/
>
>
> Testing
> -------
>
> `./mesos-tests --gtest_filter="*ExecutorShutdownGracePeriod*" --gtest_repeat=5000 --gtest_break_on_failure`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63113: Fix flakyness in
'SlaveTest.ExecutorShutdownGracePeriod'.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63113/#review188545
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63113]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 18, 2017, 3:49 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63113/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 3:49 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On slow systems, it could happen that an additional offer was
> delivered to the scheduler before the test case finished.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 91d97d195acd695ae9c469651596511eafb50557
>
>
> Diff: https://reviews.apache.org/r/63113/diff/1/
>
>
> Testing
> -------
>
> `./mesos-tests --gtest_filter="*ExecutorShutdownGracePeriod*" --gtest_repeat=5000 --gtest_break_on_failure`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63113: Fix flakyness in
'SlaveTest.ExecutorShutdownGracePeriod'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63113/#review188540
-----------------------------------------------------------
PASS: Mesos patch 63113 was successfully built and tested.
Reviews applied: `['63113']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63113
- Mesos Reviewbot Windows
On Oct. 18, 2017, 3:49 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63113/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 3:49 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On slow systems, it could happen that an additional offer was
> delivered to the scheduler before the test case finished.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 91d97d195acd695ae9c469651596511eafb50557
>
>
> Diff: https://reviews.apache.org/r/63113/diff/1/
>
>
> Testing
> -------
>
> `./mesos-tests --gtest_filter="*ExecutorShutdownGracePeriod*" --gtest_repeat=5000 --gtest_break_on_failure`
>
>
> Thanks,
>
> Benno Evers
>
>