You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2016/03/29 03:30:51 UTC

Review Request 45413: AMBARI-15611. Moving masters causes services to be shut down unnecessarily, causing downtime that's avoidable

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45413/
-----------------------------------------------------------

Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-15611
    https://issues.apache.org/jira/browse/AMBARI-15611


Repository: ambari


Description
-------

When some services like Timeline service get moved to another host, unneeded services get shut down because of not exact mapping.


Diffs
-----

  ambari-web/app/controllers/main/service/reassign/step4_controller.js 1d28834 
  ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 4406bb0 

Diff: https://reviews.apache.org/r/45413/diff/


Testing
-------

Manually tested on live cluster. All unit tests passed.
  25630 tests complete (25 seconds)
  154 tests pending


Thanks,

Richard Zang


Re: Review Request 45413: AMBARI-15611. Moving masters causes services to be shut down unnecessarily, causing downtime that's avoidable

Posted by Richard Zang <rz...@hortonworks.com>.

> On March 29, 2016, 5:39 p.m., Alejandro Fernandez wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 85
> > <https://reviews.apache.org/r/45413/diff/1/?file=1317425#file1317425line85>
> >
> >     Why is the UI tracking this and not the stack?

We are fixing this issue at FE for 2.4. We do plan to make it stack driven in future release.


- Richard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45413/#review125916
-----------------------------------------------------------


On March 29, 2016, 1:30 a.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45413/
> -----------------------------------------------------------
> 
> (Updated March 29, 2016, 1:30 a.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15611
>     https://issues.apache.org/jira/browse/AMBARI-15611
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When some services like Timeline service get moved to another host, unneeded services get shut down because of not exact mapping.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 1d28834 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 4406bb0 
> 
> Diff: https://reviews.apache.org/r/45413/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on live cluster. All unit tests passed.
>   25630 tests complete (25 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>


Re: Review Request 45413: AMBARI-15611. Moving masters causes services to be shut down unnecessarily, causing downtime that's avoidable

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45413/#review125916
-----------------------------------------------------------




ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 85)
<https://reviews.apache.org/r/45413/#comment188819>

    Why is the UI tracking this and not the stack?


- Alejandro Fernandez


On March 29, 2016, 1:30 a.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45413/
> -----------------------------------------------------------
> 
> (Updated March 29, 2016, 1:30 a.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15611
>     https://issues.apache.org/jira/browse/AMBARI-15611
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When some services like Timeline service get moved to another host, unneeded services get shut down because of not exact mapping.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 1d28834 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 4406bb0 
> 
> Diff: https://reviews.apache.org/r/45413/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on live cluster. All unit tests passed.
>   25630 tests complete (25 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>


Re: Review Request 45413: AMBARI-15611. Moving masters causes services to be shut down unnecessarily, causing downtime that's avoidable

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45413/#review125852
-----------------------------------------------------------


Ship it!




Ship It!

- Aleksandr Kovalenko


On March 29, 2016, 1:30 a.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45413/
> -----------------------------------------------------------
> 
> (Updated March 29, 2016, 1:30 a.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15611
>     https://issues.apache.org/jira/browse/AMBARI-15611
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When some services like Timeline service get moved to another host, unneeded services get shut down because of not exact mapping.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 1d28834 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 4406bb0 
> 
> Diff: https://reviews.apache.org/r/45413/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on live cluster. All unit tests passed.
>   25630 tests complete (25 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>