You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Brian Femiano <bf...@gmail.com> on 2012/10/04 17:06:37 UTC
Review Request: checkstyle updates for giraph-formats contrib. Helper
methods for Configuration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7445/
-----------------------------------------------------------
Review request for giraph and Nitay Joffe.
Description
-------
checkstyle patches and static setter methods to pass Configuration.
This addresses bug GIRAPH-350.
https://issues.apache.org/jira/browse/GIRAPH-350
Diffs
-----
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/pom.xml 1394100
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexInputFormat.java 1394100
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexOutputFormat.java 1394100
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hbase/HBaseVertexInputFormat.java 1394100
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hbase/HBaseVertexOutputFormat.java 1394100
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.java 1394100
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hcatalog/HCatalogVertexOutputFormat.java 1394100
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hcatalog/HiveGiraphRunner.java 1394100
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hcatalog/package-info.java 1394100
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/format/hbase/TestHBaseRootMarkerVertextFormat.java 1394100
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/format/hbase/edgemarker/TableEdgeInputFormat.java 1394100
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/format/hbase/edgemarker/TableEdgeOutputFormat.java 1394100
Diff: https://reviews.apache.org/r/7445/diff/
Testing
-------
Passes MVN install on the latest trunk revision update.
Thanks,
Brian Femiano
Re: Review Request: checkstyle updates for giraph-formats contrib. Helper
methods for Configuration.
Posted by Nitay Joffe <ni...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7445/#review12290
-----------------------------------------------------------
Ship it!
Ship It!
- Nitay Joffe
On Oct. 4, 2012, 3:06 p.m., Brian Femiano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7445/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2012, 3:06 p.m.)
>
>
> Review request for giraph and Nitay Joffe.
>
>
> Description
> -------
>
> checkstyle patches and static setter methods to pass Configuration.
>
>
> This addresses bug GIRAPH-350.
> https://issues.apache.org/jira/browse/GIRAPH-350
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/pom.xml 1394100
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexInputFormat.java 1394100
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexOutputFormat.java 1394100
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hbase/HBaseVertexInputFormat.java 1394100
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hbase/HBaseVertexOutputFormat.java 1394100
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.java 1394100
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hcatalog/HCatalogVertexOutputFormat.java 1394100
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hcatalog/HiveGiraphRunner.java 1394100
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hcatalog/package-info.java 1394100
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/format/hbase/TestHBaseRootMarkerVertextFormat.java 1394100
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/format/hbase/edgemarker/TableEdgeInputFormat.java 1394100
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/format/hbase/edgemarker/TableEdgeOutputFormat.java 1394100
>
> Diff: https://reviews.apache.org/r/7445/diff/
>
>
> Testing
> -------
>
> Passes MVN install on the latest trunk revision update.
>
>
> Thanks,
>
> Brian Femiano
>
>