You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/04/01 01:05:46 UTC

Re: Review Request 32591: DRILL-2590: In implicit casting rule, make boolean to be implicitly castable from BOOLEAN and TINYINT only

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32591/
-----------------------------------------------------------

(Updated March 31, 2015, 11:05 p.m.)


Review request for drill and Aman Sinha.


Changes
-------

add castable from tinyint back


Summary (updated)
-----------------

DRILL-2590: In implicit casting rule, make boolean to be implicitly castable from BOOLEAN and TINYINT only


Bugs: DRILL-2590
    https://issues.apache.org/jira/browse/DRILL-2590


Repository: drill-git


Description (updated)
-------

DRILL-2590: In implicit casting rule, make boolean to be implicitly castable from BOOLEAN and TINYINT only


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java 8fc6612 
  exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 1ebb534 
  exec/java-exec/src/test/resources/store/json/booleanData.json PRE-CREATION 
  exec/java-exec/src/test/resources/store/json/intData.json PRE-CREATION 

Diff: https://reviews.apache.org/r/32591/diff/


Testing
-------

QA, unit tests


Thanks,

Sean Hsuan-Yi Chu

Re: Review Request 32591: DRILL-2590: In implicit casting rule, make boolean to be implicitly castable from BOOLEAN and TINYINT only

Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32591/#review78440
-----------------------------------------------------------

Ship it!


Ship It!

- Aman Sinha


On March 31, 2015, 11:05 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32591/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 11:05 p.m.)
> 
> 
> Review request for drill and Aman Sinha.
> 
> 
> Bugs: DRILL-2590
>     https://issues.apache.org/jira/browse/DRILL-2590
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-2590: In implicit casting rule, make boolean to be implicitly castable from BOOLEAN and TINYINT only
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java 8fc6612 
>   exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 1ebb534 
>   exec/java-exec/src/test/resources/store/json/booleanData.json PRE-CREATION 
>   exec/java-exec/src/test/resources/store/json/intData.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32591/diff/
> 
> 
> Testing
> -------
> 
> QA, unit tests
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>