You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Jan Piotrowski <pi...@gmail.com> on 2018/01/25 23:54:29 UTC
[DISCUSS] Cordova-Windows 6.0.0
Hello.
After we had to scrap release 5.1.0 because of an unexpected breaking
change (and broken CI and failing tests), I took the time to work a
bit on this and am now planning to go forward with a 6.0.0 release of
cordova-windows soonish.
Current status:
Must
- https://github.com/apache/cordova-windows/pull/246 (of
https://issues.apache.org/jira/browse/CB-13829) has to be reviewed and
merged
- https://issues.apache.org/jira/browse/CB-13834 has to be analyzed,
fixed, reviewed and merged
Maybe
- https://issues.apache.org/jira/browse/CB-13817 could implement "UWP"
everywhere we currently use "UAP" (which will be kept as an alias)
- https://github.com/apache/cordova-windows/pull/235 should be
reviewed and merged as it is a nice new feature for Windows
After
- Later https://github.com/apache/cordova-docs/pull/785 needs some
more work so docs at least partially match reality when 6.0.0 will be
released
Am I missing anything?
In the last release email Jesse suggested dropping 8.1 alltogether.
After spending some time with the code this would a) be super nice as
soooo much stuff could be deleted and removed but also b) pretty hard
as it is all connected and interwoven. Won't be quick to do.
More importantly I think we should use the release blog post to ask
cordova-windows users if 8.1 is still needed for them and how they are
using it in general so we get some input on how to proceed. (Some
feedback from Microsoft wouldn't be the worst idea either) If no one
uses it, we can do a clean 7.0.0 that removes it.
Best,
Jan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Windows 6.0.0
Posted by Jan Piotrowski <pi...@gmail.com>.
Ok, so #235 and #246 are merged into `master` and we are down to one
failing test case https://issues.apache.org/jira/browse/CB-13834
The test is failing with Visual Studio 2017 and I can't reproduce locally,
but it happens consistently on AppVeyor CI.
If anyone here has some time, it would be really helpful if you could check
out `master` and see if you can reproduce.
(Test runs of last commit to master can be seen here:
https://ci.appveyor.com/project/Humbedooh/cordova-windows/build/1.0.854)
Best,
Jan
2018-01-26 1:42 GMT+01:00 Jan Piotrowski <pi...@gmail.com>:
> The failures in https://github.com/apache/cordova-windows/pull/235 are
> unrelated to that PR. Those are caused by the "Musts": If
> https://github.com/apache/cordova-windows/pull/246 gets merged this
> will be down to one, and the last one is
> https://issues.apache.org/jira/browse/CB-13834
>
> -J
>
> 2018-01-26 1:12 GMT+01:00 Jesse <pu...@gmail.com>:
> > Yeah, I agree that dumping 8.1 completely would be a lot of work, let
> move
> > forward without that part.
> >
> > I think I agree with all your assessments!
> >
> > For the maybes:
> > I think CB-13817 <https://issues.apache.org/jira/browse/CB-13817> is
> less
> > important, as it is something that even MS allows. They changed to call
> all
> > UAP => UWP but they still have docs that say UAP.
> > I would like to see https://github.com/apache/cordova-windows/pull/235
> make
> > it in, we'll need to look into the failures.
> >
> >
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Thu, Jan 25, 2018 at 3:54 PM, Jan Piotrowski <pi...@gmail.com>
> > wrote:
> >
> >> Hello.
> >>
> >> After we had to scrap release 5.1.0 because of an unexpected breaking
> >> change (and broken CI and failing tests), I took the time to work a
> >> bit on this and am now planning to go forward with a 6.0.0 release of
> >> cordova-windows soonish.
> >>
> >> Current status:
> >>
> >> Must
> >> - https://github.com/apache/cordova-windows/pull/246 (of
> >> https://issues.apache.org/jira/browse/CB-13829) has to be reviewed and
> >> merged
> >> - https://issues.apache.org/jira/browse/CB-13834 has to be analyzed,
> >> fixed, reviewed and merged
> >>
> >> Maybe
> >> - https://issues.apache.org/jira/browse/CB-13817 could implement "UWP"
> >> everywhere we currently use "UAP" (which will be kept as an alias)
> >> - https://github.com/apache/cordova-windows/pull/235 should be
> >> reviewed and merged as it is a nice new feature for Windows
> >>
> >> After
> >> - Later https://github.com/apache/cordova-docs/pull/785 needs some
> >> more work so docs at least partially match reality when 6.0.0 will be
> >> released
> >>
> >> Am I missing anything?
> >>
> >> In the last release email Jesse suggested dropping 8.1 alltogether.
> >> After spending some time with the code this would a) be super nice as
> >> soooo much stuff could be deleted and removed but also b) pretty hard
> >> as it is all connected and interwoven. Won't be quick to do.
> >> More importantly I think we should use the release blog post to ask
> >> cordova-windows users if 8.1 is still needed for them and how they are
> >> using it in general so we get some input on how to proceed. (Some
> >> feedback from Microsoft wouldn't be the worst idea either) If no one
> >> uses it, we can do a clean 7.0.0 that removes it.
> >>
> >> Best,
> >> Jan
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >> For additional commands, e-mail: dev-help@cordova.apache.org
> >>
> >>
>
Re: [DISCUSS] Cordova-Windows 6.0.0
Posted by Jan Piotrowski <pi...@gmail.com>.
The failures in https://github.com/apache/cordova-windows/pull/235 are
unrelated to that PR. Those are caused by the "Musts": If
https://github.com/apache/cordova-windows/pull/246 gets merged this
will be down to one, and the last one is
https://issues.apache.org/jira/browse/CB-13834
-J
2018-01-26 1:12 GMT+01:00 Jesse <pu...@gmail.com>:
> Yeah, I agree that dumping 8.1 completely would be a lot of work, let move
> forward without that part.
>
> I think I agree with all your assessments!
>
> For the maybes:
> I think CB-13817 <https://issues.apache.org/jira/browse/CB-13817> is less
> important, as it is something that even MS allows. They changed to call all
> UAP => UWP but they still have docs that say UAP.
> I would like to see https://github.com/apache/cordova-windows/pull/235 make
> it in, we'll need to look into the failures.
>
>
>
>
> @purplecabbage
> risingj.com
>
> On Thu, Jan 25, 2018 at 3:54 PM, Jan Piotrowski <pi...@gmail.com>
> wrote:
>
>> Hello.
>>
>> After we had to scrap release 5.1.0 because of an unexpected breaking
>> change (and broken CI and failing tests), I took the time to work a
>> bit on this and am now planning to go forward with a 6.0.0 release of
>> cordova-windows soonish.
>>
>> Current status:
>>
>> Must
>> - https://github.com/apache/cordova-windows/pull/246 (of
>> https://issues.apache.org/jira/browse/CB-13829) has to be reviewed and
>> merged
>> - https://issues.apache.org/jira/browse/CB-13834 has to be analyzed,
>> fixed, reviewed and merged
>>
>> Maybe
>> - https://issues.apache.org/jira/browse/CB-13817 could implement "UWP"
>> everywhere we currently use "UAP" (which will be kept as an alias)
>> - https://github.com/apache/cordova-windows/pull/235 should be
>> reviewed and merged as it is a nice new feature for Windows
>>
>> After
>> - Later https://github.com/apache/cordova-docs/pull/785 needs some
>> more work so docs at least partially match reality when 6.0.0 will be
>> released
>>
>> Am I missing anything?
>>
>> In the last release email Jesse suggested dropping 8.1 alltogether.
>> After spending some time with the code this would a) be super nice as
>> soooo much stuff could be deleted and removed but also b) pretty hard
>> as it is all connected and interwoven. Won't be quick to do.
>> More importantly I think we should use the release blog post to ask
>> cordova-windows users if 8.1 is still needed for them and how they are
>> using it in general so we get some input on how to proceed. (Some
>> feedback from Microsoft wouldn't be the worst idea either) If no one
>> uses it, we can do a clean 7.0.0 that removes it.
>>
>> Best,
>> Jan
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Windows 6.0.0
Posted by Jesse <pu...@gmail.com>.
Yeah, I agree that dumping 8.1 completely would be a lot of work, let move
forward without that part.
I think I agree with all your assessments!
For the maybes:
I think CB-13817 <https://issues.apache.org/jira/browse/CB-13817> is less
important, as it is something that even MS allows. They changed to call all
UAP => UWP but they still have docs that say UAP.
I would like to see https://github.com/apache/cordova-windows/pull/235 make
it in, we'll need to look into the failures.
@purplecabbage
risingj.com
On Thu, Jan 25, 2018 at 3:54 PM, Jan Piotrowski <pi...@gmail.com>
wrote:
> Hello.
>
> After we had to scrap release 5.1.0 because of an unexpected breaking
> change (and broken CI and failing tests), I took the time to work a
> bit on this and am now planning to go forward with a 6.0.0 release of
> cordova-windows soonish.
>
> Current status:
>
> Must
> - https://github.com/apache/cordova-windows/pull/246 (of
> https://issues.apache.org/jira/browse/CB-13829) has to be reviewed and
> merged
> - https://issues.apache.org/jira/browse/CB-13834 has to be analyzed,
> fixed, reviewed and merged
>
> Maybe
> - https://issues.apache.org/jira/browse/CB-13817 could implement "UWP"
> everywhere we currently use "UAP" (which will be kept as an alias)
> - https://github.com/apache/cordova-windows/pull/235 should be
> reviewed and merged as it is a nice new feature for Windows
>
> After
> - Later https://github.com/apache/cordova-docs/pull/785 needs some
> more work so docs at least partially match reality when 6.0.0 will be
> released
>
> Am I missing anything?
>
> In the last release email Jesse suggested dropping 8.1 alltogether.
> After spending some time with the code this would a) be super nice as
> soooo much stuff could be deleted and removed but also b) pretty hard
> as it is all connected and interwoven. Won't be quick to do.
> More importantly I think we should use the release blog post to ask
> cordova-windows users if 8.1 is still needed for them and how they are
> using it in general so we get some input on how to proceed. (Some
> feedback from Microsoft wouldn't be the worst idea either) If no one
> uses it, we can do a clean 7.0.0 that removes it.
>
> Best,
> Jan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>