You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Martin Bektchiev (JIRA)" <ji...@apache.org> on 2015/02/03 13:51:34 UTC
[jira] [Commented] (CB-7518) Android - Don't run "android" command
from within CLI/Plugman
[ https://issues.apache.org/jira/browse/CB-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303212#comment-14303212 ]
Martin Bektchiev commented on CB-7518:
--------------------------------------
android update lib-project does more than just setting the sdk.dir property. It also creates the build.xml and proguard-properties.txt files which are vital for the building of a library. This renders projects created with cordova-android using plugman unbuildable, unless the native library contains the needed files. But providing them inside the plugin makes them prone to becoming outdated and/or incorrect.
[~agrieve] Do you think that it is a good idea to remove the check and revert to unconditionally calling the command? What is so bad about requiring Android SDK when installing a plugin that contains a native library?
> Android - Don't run "android" command from within CLI/Plugman
> -------------------------------------------------------------
>
> Key: CB-7518
> URL: https://issues.apache.org/jira/browse/CB-7518
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugman
> Reporter: Andrew Grieve
> Assignee: Andrew Grieve
> Priority: Minor
>
> The Android SDK auto-detection code (e.g. location ANDROID_HOME, putting things in your PATH), is a part of cordova-android's check_reqs script, which is not called from within CLI. So, we don't want to rely on the presense of the "android" executable from within CLI.
> Currently the only time it's called is for `<framework>` within plugins. With the ANDROID_HOME changes in 3.6.0, running this isn't necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org