You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "MikeThomsen (via GitHub)" <gi...@apache.org> on 2025/06/10 20:28:47 UTC
[PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
MikeThomsen opened a new pull request, #10006:
URL: https://github.com/apache/nifi/pull/10006
…d ScyllaDB.
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on code in PR #10006:
URL: https://github.com/apache/nifi/pull/10006#discussion_r2138744412
##########
nifi-assembly/pom.xml:
##########
@@ -519,6 +519,24 @@ language governing permissions and limitations under the License. -->
<version>2.5.0-SNAPSHOT</version>
<type>nar</type>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-cql-nar</artifactId>
Review Comment:
I am not in favor of including cassandra by default in our convenenience binary. It makes great sense to build a great supportable cassandra interface again but it needs to be really well written and should not be bundled by default until we find out more about usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on code in PR #10006:
URL: https://github.com/apache/nifi/pull/10006#discussion_r2138741074
##########
nifi-extension-bundles/nifi-cql-bundle/nifi-cql-nar/pom.xml:
##########
@@ -0,0 +1,51 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
given 'nifi-cql-bundle' is the top level concept it really should say the word 'cassandra' fully written out.
so 'nifi-cassandra-bundle' at the top level at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #10006:
URL: https://github.com/apache/nifi/pull/10006#issuecomment-2971085669
I don't know what CQL is but i'm guessing Cassandra Query Language.
Im not familiar with Cassandra vs ScyllaDB
But I am very familiar with complex dependencies, maintenance, and vulnerability considerations. This one just makes me more attentive than others because it tends to tick those boxes of concern.
To be clear...I do recognize Cassandra is very popular and an excellent tool. And the nifi community is better off when we give them a great integration. I get it. I just dont have a good enough sense of this contrib in doing that.
I also noted the AI generated looking code and thought that was a potential flag. I'm not sure we can use that as is but maybe...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #10006:
URL: https://github.com/apache/nifi/pull/10006#discussion_r2231774461
##########
nifi-extension-bundles/nifi-cql-bundle/nifi-cql-services-api/src/main/java/org/apache/nifi/service/cql/api/CQLExecutionService.java:
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.service.cql.api;
+
+import com.datastax.oss.driver.api.core.ConsistencyLevel;
+import com.datastax.oss.driver.api.core.DefaultConsistencyLevel;
+import io.netty.handler.ssl.ClientAuth;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.controller.ControllerService;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.service.cql.api.exception.QueryFailureException;
+import org.apache.nifi.ssl.SSLContextService;
+
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+public interface CQLExecutionService extends ControllerService {
+ PropertyDescriptor CONTACT_POINTS = new PropertyDescriptor.Builder()
Review Comment:
These Property Descriptors should not be included on the interface. The Controller Service interface defines contract behavior, but the Property Descriptors are specific to a given implementation, and should never be included on a Controller Service interface definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "MikeThomsen (via GitHub)" <gi...@apache.org>.
MikeThomsen commented on PR #10006:
URL: https://github.com/apache/nifi/pull/10006#issuecomment-2972743763
@exceptionfactory
> If you can work through these items across the board, that would address a number of things and enable focus on the implementation itself.
Yeah. Understood. Thanks for this. FWIW, the implementation is directly inspired by how the graph bundle generally handles the interaction between its controller services and processors (since Cypher and Gremin are so radically different as protocols)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #10006:
URL: https://github.com/apache/nifi/pull/10006#discussion_r2231772830
##########
nifi-extension-bundles/nifi-cql-bundle/nifi-cql-services-api/src/main/java/org/apache/nifi/service/cql/api/CQLExecutionService.java:
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.service.cql.api;
+
+import com.datastax.oss.driver.api.core.ConsistencyLevel;
+import com.datastax.oss.driver.api.core.DefaultConsistencyLevel;
+import io.netty.handler.ssl.ClientAuth;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.controller.ControllerService;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.service.cql.api.exception.QueryFailureException;
+import org.apache.nifi.ssl.SSLContextService;
+
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+public interface CQLExecutionService extends ControllerService {
+ PropertyDescriptor CONTACT_POINTS = new PropertyDescriptor.Builder()
+ .name("Cassandra Contact Points")
+ .description("Contact points are addresses of Cassandra nodes. The list of contact points should be "
+ + "comma-separated and in hostname:port format. Example node1:port,node2:port,...."
+ + " The default client port for Cassandra is 9042, but the port(s) must be explicitly specified.")
+ .required(true)
+ .expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
+ .addValidator(StandardValidators.HOSTNAME_PORT_LIST_VALIDATOR)
+ .build();
+
+ PropertyDescriptor DATACENTER = new PropertyDescriptor.Builder()
+ .name("Cassandra Datacenter")
+ .description("The datacenter setting to use with your node/cluster.")
+ .required(true)
+ .expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ PropertyDescriptor KEYSPACE = new PropertyDescriptor.Builder()
+ .name("Default Keyspace")
+ .description("The Cassandra Keyspace to connect to. If no keyspace is specified, the query will need to " +
+ "include the keyspace name before any table reference, in case of 'query' native processors or " +
+ "if the processor supports the 'Table' property, the keyspace name has to be provided with the " +
+ "table name in the form of <KEYSPACE>.<TABLE>")
+ .required(true)
+ .expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ PropertyDescriptor PROP_SSL_CONTEXT_SERVICE = new PropertyDescriptor.Builder()
+ .name("SSL Context Service")
+ .description("The SSL Context Service used to provide client certificate information for TLS/SSL "
+ + "connections.")
+ .required(false)
+ .identifiesControllerService(SSLContextService.class)
+ .build();
+
+ PropertyDescriptor CLIENT_AUTH = new PropertyDescriptor.Builder()
Review Comment:
This property should not be used for client operations, it is only relevant to services that implement listening sockets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #10006: NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an…
URL: https://github.com/apache/nifi/pull/10006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "MikeThomsen (via GitHub)" <gi...@apache.org>.
MikeThomsen commented on code in PR #10006:
URL: https://github.com/apache/nifi/pull/10006#discussion_r2138932293
##########
nifi-extension-bundles/nifi-cql-bundle/nifi-cql-nar/pom.xml:
##########
@@ -0,0 +1,51 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
The bundle includes a driver NAR for ScyllaDB support, so I think calling it `nifi-cql-bundle` makes more sense here. That said, it's been a while AFAICT since Cassandra and ScyllaDB support were discussed, so I'm open to splitting this into two separate bundles because we can't predict where Cassandra and ScyllaDB will be in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on code in PR #10006:
URL: https://github.com/apache/nifi/pull/10006#discussion_r2138742794
##########
nifi-extension-bundles/nifi-cql-bundle/nifi-cql-nar/src/main/resources/META-INF/NOTICE:
##########
@@ -0,0 +1,328 @@
+nifi-cassandra-nar
+Copyright 2016-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+******************
+Apache Software License v2
+******************
+
+The following binary components are provided under the Apache Software License v2
+
+ (ASLv2) DataStax Java Driver for Apache Cassandra - Core
+ The following NOTICE information applies:
+ DataStax Java Driver for Apache Cassandra - Core
+ Copyright (C) 2012-2017 DataStax Inc.
+
+ (ASLv2) Apache Avro
+ The following NOTICE information applies:
+ Apache Avro
+ Copyright 2009-2017 The Apache Software Foundation
+
+ (ASLv2) Jackson JSON processor
+ The following NOTICE information applies:
+ # Jackson JSON processor
+
+ Jackson is a high-performance, Free/Open Source JSON processing library.
+ It was originally written by Tatu Saloranta (tatu.saloranta@iki.fi), and has
+ been in development since 2007.
+ It is currently developed by a community of developers, as well as supported
+ commercially by FasterXML.com.
+
+ ## Licensing
+
+ Jackson core and extension components may licensed under different licenses.
+ To find the details that apply to this artifact see the accompanying LICENSE file.
+ For more information, including possible other licensing options, contact
+ FasterXML.com (http://fasterxml.com).
+
+ ## Credits
+
+ A list of contributors may be found from CREDITS file, which is included
+ in some artifacts (usually source distributions); but is always available
+ from the source code management (SCM) system project uses.
+
+ (ASLv2) Apache Commons Codec
+ The following NOTICE information applies:
+ Apache Commons Codec
+ Copyright 2002-2014 The Apache Software Foundation
+
+ src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.java
+ contains test data from http://aspell.net/test/orig/batch0.tab.
+ Copyright (C) 2002 Kevin Atkinson (kevina@gnu.org)
+
+ ===============================================================================
+
+ The content of package org.apache.commons.codec.language.bm has been translated
+ from the original php source code available at http://stevemorse.org/phoneticinfo.htm
+ with permission from the original authors.
+ Original source copyright:
+ Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
+
+ (ASLv2) Apache Commons Compress
+ The following NOTICE information applies:
+ Apache Commons Compress
+ Copyright 2002-2017 The Apache Software Foundation
+
+ The files in the package org.apache.commons.compress.archivers.sevenz
+ were derived from the LZMA SDK, version 9.20 (C/ and CPP/7zip/),
+ which has been placed in the public domain:
+
+ "LZMA SDK is placed in the public domain." (http://www.7-zip.org/sdk.html)
+
+ (ASLv2) Apache Commons IO
+ The following NOTICE information applies:
+ Apache Commons IO
+ Copyright 2002-2016 The Apache Software Foundation
+
+ (ASLv2) Apache Commons Lang
+ The following NOTICE information applies:
+ Apache Commons Lang
+ Copyright 2001-2017 The Apache Software Foundation
+
+ This product includes software from the Spring Framework,
+ under the Apache License 2.0 (see: StringUtils.containsWhitespace())
+
+ (ASLv2) Guava
+ The following NOTICE information applies:
+ Guava
+ Copyright 2015 The Guava Authors
+
+ (ASLv2) Dropwizard Metrics
+ The following NOTICE information applies:
+ Copyright (c) 2010-2013 Coda Hale, Yammer.com
+
+ This product includes software developed by Coda Hale and Yammer, Inc.
+
+ This product includes code derived from the JSR-166 project (ThreadLocalRandom, Striped64,
+ LongAdder), which was released with the following comments:
+
+ Written by Doug Lea with assistance from members of JCP JSR-166
+ Expert Group and released to the public domain, as explained at
+ http://creativecommons.org/publicdomain/zero/1.0/
+
+ (ASLv2) The Netty Project
Review Comment:
please look for other exmaples of how we reference netty. all this text should not be needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "MikeThomsen (via GitHub)" <gi...@apache.org>.
MikeThomsen commented on PR #10006:
URL: https://github.com/apache/nifi/pull/10006#issuecomment-2960511451
@exceptionfactory @mattyb149 ScyllaDB aims for 100% compatibility at the interface level on Java drivers, and the basic testcontainers-powered testing I did seems to support it being a drop-in replacement for the Java DataStax driver.
The two "codec" Java files that are in the Cassandra provider package were generated with ChatGPT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10006:
URL: https://github.com/apache/nifi/pull/10006#issuecomment-3567201703
Automated review is marking this PR as stale due to lack of updates in the past four months. This PR will be closed in 15 days if the stale label is not removed. This stale label and automated closure does not indicate a judgement of the PR, just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale label. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on code in PR #10006:
URL: https://github.com/apache/nifi/pull/10006#discussion_r2138845903
##########
nifi-assembly/pom.xml:
##########
@@ -519,6 +519,24 @@ language governing permissions and limitations under the License. -->
<version>2.5.0-SNAPSHOT</version>
<type>nar</type>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-cql-nar</artifactId>
Review Comment:
For all external system integrations I'm in favor of a (perhaps set of) interface(s) that separate the external system's API/SDK from the NiFi components in order to BYO library so we can try to be future-proof for upcoming versions and such. This is often a lot more difficult and time-consuming than when we used to just accept all contributions that connected to these systems.
Having said that, I don't want to set a negative tone for PR contributions for external system integrations or else everyone will end up with their own private repos and NiFi's bread and butter of universal data distribution will suffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "MikeThomsen (via GitHub)" <gi...@apache.org>.
MikeThomsen commented on PR #10006:
URL: https://github.com/apache/nifi/pull/10006#issuecomment-2972741640
@joewitt
> I don't know what CQL is but i'm guessing Cassandra Query Language.
> Im not familiar with Cassandra vs ScyllaDB
TL;DR, yes CQL = Cassandra Query Language. ScyllaDB is an increasingly popular, C++ rewrite of Apache Cassandra that aims for (or seems to aim for) 100% driver API compatibility so it is a drop-in replacement as far as Cassandra users are concerned.
> I also noted the AI generated looking code and thought that was a potential flag. I'm not sure we can use that as is but maybe...
I understand the concern, but when I reviewed the output from ChatGPT the TypeCodec implementations looked like what any reasonable person would write by hand to implement those mappings so I'm not sure there is enough novelty here to raise red flags. That said, I can try to do some googling on Cassandra to see if OpenAI was taking liberties with someone else's code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-9770 Added nifi-cql-bundle to bring support for Cassandra 4.X an… [nifi]
Posted by "MikeThomsen (via GitHub)" <gi...@apache.org>.
MikeThomsen commented on PR #10006:
URL: https://github.com/apache/nifi/pull/10006#issuecomment-2970113419
@exceptionfactory We should be good to go now on the dependency update.
If you, @joewitt and @mattyb149 could weight in on keeping this as a single bundle vs two (one Cassandra, one ScyllaDB) I'd like to know your thoughts. I see more advantages in having a single, unified CQL bundle, but the disadvantage is that API divergence between the two databases could necessitate breaking compatibility later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org