You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajesh Battala <ra...@citrix.com> on 2013/03/06 06:19:48 UTC
Re: Review Request: Feature SNMP Alerts support in CloudStack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/#review17450
-----------------------------------------------------------
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java
<https://reviews.apache.org/r/9587/#comment37021>
why this class named ending with "2"?
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java
<https://reviews.apache.org/r/9587/#comment37022>
valueToken will be null or the value in it will be null?
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java
<https://reviews.apache.org/r/9587/#comment37023>
why getting the substring with fixed numbers? will it not fail if the message varies?
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
<https://reviews.apache.org/r/9587/#comment37024>
Remove blank lines and empty spaces
- Rajesh Battala
On Feb. 25, 2013, 2:23 p.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9587/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 2:23 p.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Description
> -------
>
> This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value=""/>
> <param name="SnmpManagerPorts" value=""/>
> <param name="SnmpManagerCommunities" value=""/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
>
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
> <param name="SnmpManagerPorts" value="162,162"/>
> <param name="SnmpManagerCommunities" value="public,public"/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
>
>
> Diffs
> -----
>
> client/pom.xml d532a42
> client/tomcatconf/log4j-cloud.xml.in 0866693
> core/src/com/cloud/alert/AlertManager.java a24e18c
> debian/cloud-server.install f792cc2
> plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
> plugins/pom.xml 88f617b
> server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
>
> Diff: https://reviews.apache.org/r/9587/diff/
>
>
> Testing
> -------
>
> 9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Anshul Gangwar <an...@citrix.com>.
> On March 6, 2013, 5:19 a.m., Rajesh Battala wrote:
> > plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java, line 1
> > <https://reviews.apache.org/r/9587/diff/1/?file=261699#file261699line1>
> >
> > why this class named ending with "2"?
It is suffixed with 2 due to conflict with SnmpConstants class of snmp4j library. I am using SnmpConstants of snmp4j library also in the same class so it is suffixed with 2 to increase the readability.
- Anshul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/#review17450
-----------------------------------------------------------
On Feb. 25, 2013, 2:23 p.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9587/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 2:23 p.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Description
> -------
>
> This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value=""/>
> <param name="SnmpManagerPorts" value=""/>
> <param name="SnmpManagerCommunities" value=""/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
>
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
> <param name="SnmpManagerPorts" value="162,162"/>
> <param name="SnmpManagerCommunities" value="public,public"/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
>
>
> Diffs
> -----
>
> client/pom.xml d532a42
> client/tomcatconf/log4j-cloud.xml.in 0866693
> core/src/com/cloud/alert/AlertManager.java a24e18c
> debian/cloud-server.install f792cc2
> plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
> plugins/pom.xml 88f617b
> server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
>
> Diff: https://reviews.apache.org/r/9587/diff/
>
>
> Testing
> -------
>
> 9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
>
>
> Thanks,
>
> Anshul Gangwar
>
>