You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/09/23 20:33:26 UTC

[GitHub] [ignite-3] kgusakov commented on a change in pull request #344: IGNITE-15492 Check schema availability on local node

kgusakov commented on a change in pull request #344:
URL: https://github.com/apache/ignite-3/pull/344#discussion_r715129863



##########
File path: modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
##########
@@ -164,7 +165,7 @@ public TableManager(
                         @Override public @NotNull CompletableFuture<?> onCreate(
                             @NotNull ConfigurationNotificationEvent<SchemaView> schemasCtx) {
                             try {
-                                ((SchemaRegistryImpl)tables.get(ctx.newValue().name()).schemaRegistry()).
+                                ((SchemaRegistryImpl)tables.get(ctx.newValue().name()).schemaView()).

Review comment:
       Could you explain removing `schemaRegistry` method from `AbstractTableView` and replacing it by `schemaView` in `TableImpl`, which returns `SchemaRegistry`despite of the name?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org