You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/03/05 14:53:18 UTC
[GitHub] [parquet-mr] andersonm-ibm opened a new pull request #878: PARQUET-1992: Manually download interop files inside the test and move encryption interop test to maven integration-test phase
andersonm-ibm opened a new pull request #878:
URL: https://github.com/apache/parquet-mr/pull/878
This PR is another option of solving the problem "Cannot build from tarball because of git submodules".
1. Encryption interop tests run separately from unit tests - in integration-test phase
2. Files for interop tests are downloaded manually, so git submodules are totally removed from the project
- `mvn package/install` - doesn't run interop tests
- `mvn verify` - run interop test and download files for interop from GitHub directly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #878: PARQUET-1992: Manually download interop files inside the test and move encryption interop test to maven integration-test phase
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on a change in pull request #878:
URL: https://github.com/apache/parquet-mr/pull/878#discussion_r591264380
##########
File path: .gitignore
##########
@@ -19,3 +19,4 @@ target/
.cache
*~
mvn_install.log
+parquet-hadoop/parquet-testing
Review comment:
Since you are using
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #878: PARQUET-1992: Manually download interop files inside the test and move encryption interop test to maven integration-test phase
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on a change in pull request #878:
URL: https://github.com/apache/parquet-mr/pull/878#discussion_r589627173
##########
File path: parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java
##########
@@ -299,13 +309,15 @@ public void testWriteReadEncryptedParquetFiles() throws IOException {
testReadEncryptedParquetFiles(rootPath, DATA);
}
- @Test
- public void testInteropReadEncryptedParquetFiles() throws IOException {
+ public void testInteropReadEncryptedParquetFiles(ErrorCollector errorCollector, OkHttpClient httpClient) throws IOException {
Review comment:
Please add some notes that this method is deliberately not annotated by `@Test` and used elsewhere.
##########
File path: parquet-hadoop/src/test/java/org/apache/parquet/hadoop/ITTestEncryptionOptions.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.parquet.hadoop;
+
+import org.junit.Test;
+import org.junit.Rule;
+import org.junit.rules.ErrorCollector;
+
+import okhttp3.OkHttpClient;
+
+
+import java.io.IOException;
+
+/*
+ * This file continues the testing in TestEncryptionOptions. This test goals:
+ * 4) Perform interoperability tests with other (eg parquet-cpp) writers, by reading
Review comment:
The number `4` does not make too much sense here.
##########
File path: .gitignore
##########
@@ -19,3 +19,4 @@ target/
.cache
*~
mvn_install.log
+parquet-hadoop/parquet-testing
Review comment:
I would suggest using either a temporary directory outside of source tree or a place the files inside the `target` directory. `target` would have the benefit that it is not cleaned until explicitly invoked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #878: PARQUET-1992: Manually download interop files inside the test and move encryption interop test to maven integration-test phase
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on a change in pull request #878:
URL: https://github.com/apache/parquet-mr/pull/878#discussion_r591264845
##########
File path: .gitignore
##########
@@ -19,3 +19,4 @@ target/
.cache
*~
mvn_install.log
+parquet-hadoop/parquet-testing
Review comment:
Since you are using `target` now this change is unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky merged pull request #878: PARQUET-1992: Manually download interop files inside the test and move encryption interop test to maven integration-test phase
Posted by GitBox <gi...@apache.org>.
gszadovszky merged pull request #878:
URL: https://github.com/apache/parquet-mr/pull/878
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org