You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/10 13:30:41 UTC

[GitHub] [spark] chasingegg commented on pull request #35290: [SPARK-37865][SQL][3.0]Fix union bug when the first child of union has duplicate columns

chasingegg commented on pull request #35290:
URL: https://github.com/apache/spark/pull/35290#issuecomment-1034924638


   I am still not very clear about your approach, maybe I misunderstand it. So if we have select a, a union a, b. And assume we get `1, 1 union 1, 2`, the correct result is  `(1, 1), (1, 2)`. As your approach goes, if we `select a from (select a, a union a, b)`, it will produce `1, 1`, am I right? But I think it is proper to make such sql broken because it is ambiguous, `1, 1` or `1, 2` are neither correct. If my understanding is right, I would prefer to fix it only in the master with my approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org