[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #607: nimble/gatt: fix custom notify/indicate to work with proper connection handle

[GitBox <gi...@apache.org>]

rymanluk commented on a change in pull request #607: nimble/gatt: fix custom notify/indicate to work with proper connection handle
URL: https://github.com/apache/mynewt-nimble/pull/607#discussion_r337714535
 
 

 ##########
 File path: nimble/host/src/ble_gattc.c
 ##########
 @@ -4166,8 +4166,8 @@ ble_gattc_notify_custom(uint16_t conn_handle, uint16_t chr_val_handle,
             rc = BLE_HS_ENOMEM;
             goto done;
         }
-        rc = ble_att_svr_read_handle(BLE_HS_CONN_HANDLE_NONE,
-                                     chr_val_handle, 0, txom, NULL);
+        rc = ble_att_svr_read_handle(conn_handle |
 
 Review comment:
   what will happen if we change here on from `BLE_HS_CONN_HANDLE_NONE` to `conn_handle` ?
   
   I understand that there will be ` ble_att_svr_check_perms` triggered, but does it creates any issues?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services